auxdisplay: seg-led-gpio: Import linedisp namespace

[PATCH] auxdisplay: seg-led-gpio: Import linedisp namespace

Posted by Chris Packham 1 year, 11 months ago

The seg-led-gpio driver uses symbols from the linedisp namespace. Ensure
these are imported.

Fixes: 899383f9ecf5 ("auxdisplay: Add 7-segment LED display driver")
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
 drivers/auxdisplay/seg-led-gpio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/auxdisplay/seg-led-gpio.c b/drivers/auxdisplay/seg-led-gpio.c
index 5dc2a006cac5..35a8dbb1e9d2 100644
--- a/drivers/auxdisplay/seg-led-gpio.c
+++ b/drivers/auxdisplay/seg-led-gpio.c
@@ -110,3 +110,4 @@ module_platform_driver(seg_led_driver);
 MODULE_AUTHOR("Chris Packham <chris.packham@alliedtelesis.co.nz>");
 MODULE_DESCRIPTION("7 segment LED driver");
 MODULE_LICENSE("GPL");
+MODULE_IMPORT_NS(LINEDISP);
-- 
2.43.2

Re: [PATCH] auxdisplay: seg-led-gpio: Import linedisp namespace

Posted by Geert Uytterhoeven 1 year, 11 months ago

On Sun, Mar 10, 2024 at 10:13 PM Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:
> The seg-led-gpio driver uses symbols from the linedisp namespace. Ensure
> these are imported.
>
> Fixes: 899383f9ecf5 ("auxdisplay: Add 7-segment LED display driver")

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202403100401.IDre04gu-lkp@intel.com/

> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] auxdisplay: seg-led-gpio: Import linedisp namespace

Posted by Andy Shevchenko 1 year, 11 months ago

On Mon, Mar 11, 2024 at 10:46:17AM +0100, Geert Uytterhoeven wrote:
> On Sun, Mar 10, 2024 at 10:13 PM Chris Packham
> <chris.packham@alliedtelesis.co.nz> wrote:
> > The seg-led-gpio driver uses symbols from the linedisp namespace. Ensure
> > these are imported.
> >
> > Fixes: 899383f9ecf5 ("auxdisplay: Add 7-segment LED display driver")
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/r/202403100401.IDre04gu-lkp@intel.com/
> 
> > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> 
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko