.../bindings/mfd/x-powers,axp152.yaml | 2 + drivers/mfd/axp20x-i2c.c | 2 + drivers/mfd/axp20x-rsb.c | 1 + drivers/mfd/axp20x.c | 90 +++++++++++++++++ drivers/regulator/axp20x-regulator.c | 94 +++++++++++++++++- include/linux/mfd/axp20x.h | 98 ++++++++++++++++++- 6 files changed, 277 insertions(+), 10 deletions(-)
This patch series adds support for the X-Powers AXP717 PMIC, which is used recently on new boards with Allwinner SoCs. Allwinner's BSP code often speaks of the AXP2202, this seems to be the same chip, at least a boot0 AXP2202 driver happily drove a chip labelled AXP717. Patch 1 fixes a typo in some macro names for the AXP313a PMIC, I just realised that during some copy&paste action. It's just an identifier rename, so not a backport candidate, I'd say. Patch 2 adds the compatible string to the binding document. Patch 3 is the MFD part, describing the regmap and all the interrupts. So far we support the regulator and power key devices, the USB and charging devices will follow later. Patch 4 adds the voltage regulator rails, this part is crucial to enable any board using this PMIC, as we depend on those rails even for basic devices. Please note that I could not test this driver myself, but had success messages from others. It would be good to hear from Ryan and Chris here on the list, with a Tested-by: tag. This series is based on next-20240308 for now. I will send a rebased update after the merge window, but wanted to start discussion and review now. Please have a look! Cheers, Andre Andre Przywara (4): regulator: axp20x: fix typo-ed identifier dt-bindings: mfd: x-powers,axp152: document AXP717 mfd: axp20x: add support for AXP717 PMIC regulator: axp20x: add support for the AXP717 .../bindings/mfd/x-powers,axp152.yaml | 2 + drivers/mfd/axp20x-i2c.c | 2 + drivers/mfd/axp20x-rsb.c | 1 + drivers/mfd/axp20x.c | 90 +++++++++++++++++ drivers/regulator/axp20x-regulator.c | 94 +++++++++++++++++- include/linux/mfd/axp20x.h | 98 ++++++++++++++++++- 6 files changed, 277 insertions(+), 10 deletions(-) -- 2.35.8
On Sun, 10 Mar 2024, at 2:02 PM, Andre Przywara wrote: > This patch series adds support for the X-Powers AXP717 PMIC, which is > used recently on new boards with Allwinner SoCs. > Please note that I could not test this driver myself, but had success > messages from others. It would be good to hear from Ryan and Chris > here on the list, with a Tested-by: tag. Thanks Andre, tested on an Allwinner H700-based board (Anbernic RG35XX+) with successful bringup of DRAM, boot and regulator reporting via /sys/kernel/debug/regulator/regulator_summary. Battery charging not tested but according to vendor datasheet this functionality is internal to the PMIC and can complete without reference to the host, with informational reporting and charging parameters optionally modified by host over I2C or RSB. Ryan Tested-by: Ryan Walklin <ryan@testtoast.com>
On Sun, 10 Mar 2024, Andre Przywara wrote: > This patch series adds support for the X-Powers AXP717 PMIC, which is > used recently on new boards with Allwinner SoCs. > Allwinner's BSP code often speaks of the AXP2202, this seems to be the > same chip, at least a boot0 AXP2202 driver happily drove a chip labelled > AXP717. > > Patch 1 fixes a typo in some macro names for the AXP313a PMIC, I just > realised that during some copy&paste action. It's just an identifier > rename, so not a backport candidate, I'd say. > Patch 2 adds the compatible string to the binding document. > Patch 3 is the MFD part, describing the regmap and all the interrupts. > So far we support the regulator and power key devices, the USB and > charging devices will follow later. > Patch 4 adds the voltage regulator rails, this part is crucial to enable > any board using this PMIC, as we depend on those rails even for basic > devices. > > Please note that I could not test this driver myself, but had success > messages from others. It would be good to hear from Ryan and Chris > here on the list, with a Tested-by: tag. > > This series is based on next-20240308 for now. I will send a rebased > update after the merge window, but wanted to start discussion and review > now. > > Please have a look! > > Cheers, > Andre > > Andre Przywara (4): > regulator: axp20x: fix typo-ed identifier > dt-bindings: mfd: x-powers,axp152: document AXP717 > mfd: axp20x: add support for AXP717 PMIC > regulator: axp20x: add support for the AXP717 > > .../bindings/mfd/x-powers,axp152.yaml | 2 + > drivers/mfd/axp20x-i2c.c | 2 + > drivers/mfd/axp20x-rsb.c | 1 + > drivers/mfd/axp20x.c | 90 +++++++++++++++++ > drivers/regulator/axp20x-regulator.c | 94 +++++++++++++++++- > include/linux/mfd/axp20x.h | 98 ++++++++++++++++++- > 6 files changed, 277 insertions(+), 10 deletions(-) All applied and sent for build testing. If everything works out, I'll send out a pull-request to an immutable branch shortly. -- Lee Jones [李琼斯]
On Thu, 21 Mar 2024, Lee Jones wrote: > On Sun, 10 Mar 2024, Andre Przywara wrote: > > > This patch series adds support for the X-Powers AXP717 PMIC, which is > > used recently on new boards with Allwinner SoCs. > > Allwinner's BSP code often speaks of the AXP2202, this seems to be the > > same chip, at least a boot0 AXP2202 driver happily drove a chip labelled > > AXP717. > > > > Patch 1 fixes a typo in some macro names for the AXP313a PMIC, I just > > realised that during some copy&paste action. It's just an identifier > > rename, so not a backport candidate, I'd say. > > Patch 2 adds the compatible string to the binding document. > > Patch 3 is the MFD part, describing the regmap and all the interrupts. > > So far we support the regulator and power key devices, the USB and > > charging devices will follow later. > > Patch 4 adds the voltage regulator rails, this part is crucial to enable > > any board using this PMIC, as we depend on those rails even for basic > > devices. > > > > Please note that I could not test this driver myself, but had success > > messages from others. It would be good to hear from Ryan and Chris > > here on the list, with a Tested-by: tag. > > > > This series is based on next-20240308 for now. I will send a rebased > > update after the merge window, but wanted to start discussion and review > > now. > > > > Please have a look! > > > > Cheers, > > Andre > > > > Andre Przywara (4): > > regulator: axp20x: fix typo-ed identifier > > dt-bindings: mfd: x-powers,axp152: document AXP717 > > mfd: axp20x: add support for AXP717 PMIC > > regulator: axp20x: add support for the AXP717 > > > > .../bindings/mfd/x-powers,axp152.yaml | 2 + > > drivers/mfd/axp20x-i2c.c | 2 + > > drivers/mfd/axp20x-rsb.c | 1 + > > drivers/mfd/axp20x.c | 90 +++++++++++++++++ > > drivers/regulator/axp20x-regulator.c | 94 +++++++++++++++++- > > include/linux/mfd/axp20x.h | 98 ++++++++++++++++++- > > 6 files changed, 277 insertions(+), 10 deletions(-) > > All applied and sent for build testing. If everything works out, I'll > send out a pull-request to an immutable branch shortly. Okay, these are building okay based on v6.8. I'll send out a PR once I can rebase tem onto v6.9-rc1. Note to self: ib-mfd-regulator-6.9 -- Lee Jones [李琼斯]
Enjoy!
The following changes since commit 4cece764965020c22cff7665b18a012006359095:
Linux 6.9-rc1 (2024-03-24 14:10:05 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-regulator-v6.9
for you to fetch changes up to d2ac3df75c3a995064cfac0171e082a30d8c4c66:
regulator: axp20x: add support for the AXP717 (2024-03-28 09:51:03 +0000)
----------------------------------------------------------------
Immutable branch between MFD and Regulator due for the v6.9 merge window
----------------------------------------------------------------
Andre Przywara (4):
regulator: axp20x: fix typo-ed identifier
dt-bindings: mfd: x-powers,axp152: Document AXP717
mfd: axp20x: Add support for AXP717 PMIC
regulator: axp20x: add support for the AXP717
.../devicetree/bindings/mfd/x-powers,axp152.yaml | 2 +
drivers/mfd/axp20x-i2c.c | 2 +
drivers/mfd/axp20x-rsb.c | 1 +
drivers/mfd/axp20x.c | 90 ++++++++++++++++++++
drivers/regulator/axp20x-regulator.c | 94 +++++++++++++++++++--
include/linux/mfd/axp20x.h | 98 ++++++++++++++++++++--
6 files changed, 277 insertions(+), 10 deletions(-)
--
Lee Jones [李琼斯]
On Thu, 28 Mar 2024 09:56:31 +0000 Lee Jones <lee@kernel.org> wrote: Hi Lee, many thanks for picking this up! > Enjoy! > > The following changes since commit 4cece764965020c22cff7665b18a012006359095: > > Linux 6.9-rc1 (2024-03-24 14:10:05 -0700) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-regulator-v6.9 > > for you to fetch changes up to d2ac3df75c3a995064cfac0171e082a30d8c4c66: > > regulator: axp20x: add support for the AXP717 (2024-03-28 09:51:03 +0000) > > ---------------------------------------------------------------- > Immutable branch between MFD and Regulator due for the v6.9 merge window Did you mean v6.10 merge window? Or is there a plan to merge this into 6.9 still? Also I found some issue with the LDOs' supply voltage: there are not all the same, as described right now. Fix is quite easy, how do you want to take this? As a follow up patch? And would this be squashed or kept separate? Or do you want we to send a new version? If yes, based on what branch? Thanks, Andre > > ---------------------------------------------------------------- > Andre Przywara (4): > regulator: axp20x: fix typo-ed identifier > dt-bindings: mfd: x-powers,axp152: Document AXP717 > mfd: axp20x: Add support for AXP717 PMIC > regulator: axp20x: add support for the AXP717 > > .../devicetree/bindings/mfd/x-powers,axp152.yaml | 2 + > drivers/mfd/axp20x-i2c.c | 2 + > drivers/mfd/axp20x-rsb.c | 1 + > drivers/mfd/axp20x.c | 90 ++++++++++++++++++++ > drivers/regulator/axp20x-regulator.c | 94 +++++++++++++++++++-- > include/linux/mfd/axp20x.h | 98 ++++++++++++++++++++-- > 6 files changed, 277 insertions(+), 10 deletions(-) >
On Thu, 28 Mar 2024, Andre Przywara wrote: > On Thu, 28 Mar 2024 09:56:31 +0000 > Lee Jones <lee@kernel.org> wrote: > > Hi Lee, > > many thanks for picking this up! > > > Enjoy! > > > > The following changes since commit 4cece764965020c22cff7665b18a012006359095: > > > > Linux 6.9-rc1 (2024-03-24 14:10:05 -0700) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-regulator-v6.9 > > > > for you to fetch changes up to d2ac3df75c3a995064cfac0171e082a30d8c4c66: > > > > regulator: axp20x: add support for the AXP717 (2024-03-28 09:51:03 +0000) > > > > ---------------------------------------------------------------- > > Immutable branch between MFD and Regulator due for the v6.9 merge window > > Did you mean v6.10 merge window? Or is there a plan to merge this into > 6.9 still? Yes - off-by-one! > Also I found some issue with the LDOs' supply voltage: there are not > all the same, as described right now. Fix is quite easy, how do you > want to take this? As a follow up patch? And would this be squashed or > kept separate? > Or do you want we to send a new version? If yes, based on what branch? Please submit a fix-up. I'll sent out a new (ib-mfd-regulator-v6.9-1) PR based on this one. > > ---------------------------------------------------------------- > > Andre Przywara (4): > > regulator: axp20x: fix typo-ed identifier > > dt-bindings: mfd: x-powers,axp152: Document AXP717 > > mfd: axp20x: Add support for AXP717 PMIC > > regulator: axp20x: add support for the AXP717 > > > > .../devicetree/bindings/mfd/x-powers,axp152.yaml | 2 + > > drivers/mfd/axp20x-i2c.c | 2 + > > drivers/mfd/axp20x-rsb.c | 1 + > > drivers/mfd/axp20x.c | 90 ++++++++++++++++++++ > > drivers/regulator/axp20x-regulator.c | 94 +++++++++++++++++++-- > > include/linux/mfd/axp20x.h | 98 ++++++++++++++++++++-- > > 6 files changed, 277 insertions(+), 10 deletions(-) > > > -- Lee Jones [李琼斯]
On Thu, 28 Mar 2024, Lee Jones wrote: > On Thu, 28 Mar 2024, Andre Przywara wrote: > > > On Thu, 28 Mar 2024 09:56:31 +0000 > > Lee Jones <lee@kernel.org> wrote: > > > > Hi Lee, > > > > many thanks for picking this up! > > > > > Enjoy! > > > > > > The following changes since commit 4cece764965020c22cff7665b18a012006359095: > > > > > > Linux 6.9-rc1 (2024-03-24 14:10:05 -0700) > > > > > > are available in the Git repository at: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-regulator-v6.9 > > > > > > for you to fetch changes up to d2ac3df75c3a995064cfac0171e082a30d8c4c66: > > > > > > regulator: axp20x: add support for the AXP717 (2024-03-28 09:51:03 +0000) > > > > > > ---------------------------------------------------------------- > > > Immutable branch between MFD and Regulator due for the v6.9 merge window > > > > Did you mean v6.10 merge window? Or is there a plan to merge this into > > 6.9 still? > > Yes - off-by-one! Just recreated ib-mfd-regulator-v6.10 for all the OCD types (like me!). -- Lee Jones [李琼斯]
© 2016 - 2026 Red Hat, Inc.