[PATCH v2 0/5] s390/vfio-ap: queue_configuration sysfs attribute for mdevctl automation

Jason J. Herne posted 5 patches 1 year, 9 months ago
Documentation/arch/s390/vfio-ap.rst   |  27 ++++
drivers/s390/crypto/ap_bus.c          |  13 +-
drivers/s390/crypto/ap_bus.h          |  22 +++
drivers/s390/crypto/vfio_ap_ops.c     | 206 ++++++++++++++++++++++++--
drivers/s390/crypto/vfio_ap_private.h |   6 +-
5 files changed, 245 insertions(+), 29 deletions(-)
[PATCH v2 0/5] s390/vfio-ap: queue_configuration sysfs attribute for mdevctl automation
Posted by Jason J. Herne 1 year, 9 months ago
Mdevctl requires a way to atomically query and atomically update a vfio-ap
mdev's current state. This patch set creates the queue_configuration sysfs
attribute.  This new attribute allows reading and writing an mdev's entire
state in one go. If a newly written state is invalid for any reason the entire
state is rejected and the target mdev remains unchanged.

Changelog
==========
v2
  - Rebased patched on top of latest master
  - Reworked code to fit changes introduced by f848cba767e59
      s390/vfio-ap: reset queues filtered from the guest's AP config
  - Moved docs changes to separate patch

Jason J. Herne (5):
  s390/ap: Externalize AP bus specific bitmap reading function
  s390/vfio-ap: Add sysfs attr, queue_configuration, to export mdev
    state
  s390/vfio-ap: Ignore duplicate link requests in
    vfio_ap_mdev_link_queue
  s390/vfio-ap: Add write support to sysfs attr ap_config
  s390: doc: Update doc

 Documentation/arch/s390/vfio-ap.rst   |  27 ++++
 drivers/s390/crypto/ap_bus.c          |  13 +-
 drivers/s390/crypto/ap_bus.h          |  22 +++
 drivers/s390/crypto/vfio_ap_ops.c     | 206 ++++++++++++++++++++++++--
 drivers/s390/crypto/vfio_ap_private.h |   6 +-
 5 files changed, 245 insertions(+), 29 deletions(-)

-- 
2.41.0
Re: [PATCH v2 0/5] s390/vfio-ap: queue_configuration sysfs attribute for mdevctl automation
Posted by Matthew Rosato 1 year, 9 months ago
On 3/6/24 9:08 AM, Jason J. Herne wrote:
> Mdevctl requires a way to atomically query and atomically update a vfio-ap
> mdev's current state. This patch set creates the queue_configuration sysfs

Less important than the patches themselves, but s/queue_configuration/ap_config/ here as well as title of cover letter.
Re: [PATCH v2 0/5] s390/vfio-ap: queue_configuration sysfs attribute for mdevctl automation
Posted by Matthew Rosato 1 year, 9 months ago
On 3/6/24 9:08 AM, Jason J. Herne wrote:
> Mdevctl requires a way to atomically query and atomically update a vfio-ap
> mdev's current state. This patch set creates the queue_configuration sysfs
> attribute.  This new attribute allows reading and writing an mdev's entire
> state in one go. If a newly written state is invalid for any reason the entire
> state is rejected and the target mdev remains unchanged.
> 
> Changelog
> ==========
> v2
>   - Rebased patched on top of latest master
>   - Reworked code to fit changes introduced by f848cba767e59
>       s390/vfio-ap: reset queues filtered from the guest's AP config
>   - Moved docs changes to separate patch

Tested exploitation of the new sysfs interface using proposed s390-tools code + mdevctl.  Besides the other minor changes mentioned separately, feel free to include

Tested-by: Matthew Rosato <mjrosato@linux.ibm.com>

for the code patches.