pps: use cflags-y instead of EXTRA_CFLAGS

[PATCH] pps: use cflags-y instead of EXTRA_CFLAGS

Posted by Lukas Bulwahn 1 year, 9 months ago

Commit f77bf01425b1 ("kbuild: introduce ccflags-y, asflags-y and
ldflags-y") deprecates use of EXTRA_CFLAGS in the kernel build.

This has been cleaned up in the whole kernel tree long ago, but this one
single place must have been missed.

Replace the EXTRA_CFLAGS use by the common pattern for such debug flags.
No functional change.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Rodolfo, please ack.

Greg, please pick this minor cleanup patch.

 drivers/pps/generators/Makefile | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pps/generators/Makefile b/drivers/pps/generators/Makefile
index 2d56dd0495d5..2589fd0f2481 100644
--- a/drivers/pps/generators/Makefile
+++ b/drivers/pps/generators/Makefile
@@ -5,6 +5,4 @@
 
 obj-$(CONFIG_PPS_GENERATOR_PARPORT) += pps_gen_parport.o
 
-ifeq ($(CONFIG_PPS_DEBUG),y)
-EXTRA_CFLAGS += -DDEBUG
-endif
+ccflags-$(CONFIG_PPS_DEBUG) := -DDEBUG
-- 
2.43.2

Re: [PATCH] pps: use cflags-y instead of EXTRA_CFLAGS

Posted by Rodolfo Giometti 1 year, 9 months ago

On 06/03/24 13:05, Lukas Bulwahn wrote:
> Commit f77bf01425b1 ("kbuild: introduce ccflags-y, asflags-y and
> ldflags-y") deprecates use of EXTRA_CFLAGS in the kernel build.
> 
> This has been cleaned up in the whole kernel tree long ago, but this one
> single place must have been missed.
> 
> Replace the EXTRA_CFLAGS use by the common pattern for such debug flags.
> No functional change.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

Acked-by: Rodolfo Giometti <giometti@enneenne.com>

> ---
> Rodolfo, please ack.
> 
> Greg, please pick this minor cleanup patch.
> 
>   drivers/pps/generators/Makefile | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/pps/generators/Makefile b/drivers/pps/generators/Makefile
> index 2d56dd0495d5..2589fd0f2481 100644
> --- a/drivers/pps/generators/Makefile
> +++ b/drivers/pps/generators/Makefile
> @@ -5,6 +5,4 @@
>   
>   obj-$(CONFIG_PPS_GENERATOR_PARPORT) += pps_gen_parport.o
>   
> -ifeq ($(CONFIG_PPS_DEBUG),y)
> -EXTRA_CFLAGS += -DDEBUG
> -endif
> +ccflags-$(CONFIG_PPS_DEBUG) := -DDEBUG

-- 
GNU/Linux Solutions                  e-mail: giometti@enneenne.com
Linux Device Driver                          giometti@linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming