kselftest/tty: Improve integration with automated systems

[PATCH 0/2] kselftest/tty: Improve integration with automated systems

Posted by Mark Brown 1 year, 9 months ago

This cleans up the output of the tty_tstamp_update selftest to play a
bit more nicely with automated systems parsing the test output.

To do this I've also added a new helper ksft_test_result() which takes a
KSFT_ code as a report, this is something I've wanted on other occasions
but restructured things to avoid needing it.  This time I figured I'd
just add it since it keeps coming up.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
Mark Brown (2):
      kselftest: Add mechanism for reporting a KSFT_ result code
      kselftest/tty: Report a consistent test name for the one test we run

 tools/testing/selftests/kselftest.h             | 22 ++++++++++++
 tools/testing/selftests/tty/tty_tstamp_update.c | 48 +++++++++++++++++--------
 2 files changed, 55 insertions(+), 15 deletions(-)
---
base-commit: 54be6c6c5ae8e0d93a6c4641cb7528eb0b6ba478
change-id: 20240305-kselftest-tty-tname-5411444ce037

Best regards,
-- 
Mark Brown <broonie@kernel.org>

Re: [PATCH 0/2] kselftest/tty: Improve integration with automated systems

Posted by Greg Kroah-Hartman 1 year, 9 months ago

On Wed, Mar 06, 2024 at 07:21:24PM +0000, Mark Brown wrote:
> This cleans up the output of the tty_tstamp_update selftest to play a
> bit more nicely with automated systems parsing the test output.
> 
> To do this I've also added a new helper ksft_test_result() which takes a
> KSFT_ code as a report, this is something I've wanted on other occasions
> but restructured things to avoid needing it.  This time I figured I'd
> just add it since it keeps coming up.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Re: [PATCH 0/2] kselftest/tty: Improve integration with automated systems

Posted by Shuah Khan 1 year, 8 months ago

On 3/6/24 15:51, Greg Kroah-Hartman wrote:
> On Wed, Mar 06, 2024 at 07:21:24PM +0000, Mark Brown wrote:
>> This cleans up the output of the tty_tstamp_update selftest to play a
>> bit more nicely with automated systems parsing the test output.
>>
>> To do this I've also added a new helper ksft_test_result() which takes a
>> KSFT_ code as a report, this is something I've wanted on other occasions
>> but restructured things to avoid needing it.  This time I figured I'd
>> just add it since it keeps coming up.
>>
>> Signed-off-by: Mark Brown <broonie@kernel.org>
> 
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


Thank you. Applied to linux-kselftest next for 6.10-rc1.

thanks,
-- Shuah

Re: [PATCH 0/2] kselftest/tty: Improve integration with automated systems

Posted by Mark Brown 1 year, 8 months ago

On Tue, Mar 26, 2024 at 01:49:11PM -0600, Shuah Khan wrote:
> On 3/6/24 15:51, Greg Kroah-Hartman wrote:
> > On Wed, Mar 06, 2024 at 07:21:24PM +0000, Mark Brown wrote:

> > > This cleans up the output of the tty_tstamp_update selftest to play a
> > > bit more nicely with automated systems parsing the test output.
> > > 
> > > To do this I've also added a new helper ksft_test_result() which takes a
> > > KSFT_ code as a report, this is something I've wanted on other occasions
> > > but restructured things to avoid needing it.  This time I figured I'd
> > > just add it since it keeps coming up.

> > > Signed-off-by: Mark Brown <broonie@kernel.org>

> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

> Thank you. Applied to linux-kselftest next for 6.10-rc1.

Thanks, but note that I sent a v2 based on v6.9-rc1 which drops the
first patch in favour of using the newly added ksft_test_result_code()
which does something similar (though with a slightly less idiomatic
API).