drivers/net/usb/sr9800.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Add check for usbnet_get_endpoints() and return the error if it fails
in order to transfer the error.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/net/usb/sr9800.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/sr9800.c b/drivers/net/usb/sr9800.c
index 143bd4ab160d..57947a5590cc 100644
--- a/drivers/net/usb/sr9800.c
+++ b/drivers/net/usb/sr9800.c
@@ -737,7 +737,9 @@ static int sr9800_bind(struct usbnet *dev, struct usb_interface *intf)
data->eeprom_len = SR9800_EEPROM_LEN;
- usbnet_get_endpoints(dev, intf);
+ ret = usbnet_get_endpoints(dev, intf);
+ if (ret)
+ goto out;
/* LED Setting Rule :
* AABB:CCDD
--
2.25.1
On Tue, Mar 05, 2024 at 07:59:27AM +0000, Chen Ni wrote:
> Add check for usbnet_get_endpoints() and return the error if it fails
> in order to transfer the error.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Hi Chen Ni,
I guess that this is a bug fix and as such it should be targeted
at the net tree and annotated as such:
Subject: [PATCH net] ...
And have a fixes tag, perhaps:
Fixes: 19a38d8e0aa3 ("USB2NET : SR9800 : One chip USB2.0 USB2NET SR9800 Device Driver Support")
I don't think there is a need to repost to address the above,
but please keep it in mind for future Networking patch submissions.
Link: https://docs.kernel.org/process/maintainer-netdev.html
The above notwithstanding, this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
...
On 05.03.24 08:59, Chen Ni wrote: > Add check for usbnet_get_endpoints() and return the error if it fails > in order to transfer the error. Hi, thank you for the patch. The asix driver also fails to check for that failure. Could you make a similar patch? Regards Oliver
© 2016 - 2025 Red Hat, Inc.