[PATCH] Removed blocking_link field description to prevent kernel doc warning

R SUNDAR posted 1 patch 2 years, 4 months ago
net/tipc/socket.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] Removed blocking_link field description to prevent kernel doc warning
Posted by R SUNDAR 2 years, 4 months ago
./net/tipc/socket.c:143: warning: Excess struct member 'blocking_link' description in 'tipc_sock'

Signed-off-by: R SUNDAR <prosunofficial@gmail.com>
---
 net/tipc/socket.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index bb1118d02f95..7e4135db5816 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -80,7 +80,6 @@ struct sockaddr_pair {
  * @phdr: preformatted message header used when sending messages
  * @cong_links: list of congested links
  * @publications: list of publications for port
- * @blocking_link: address of the congested link we are currently sleeping on
  * @pub_count: total # of publications port has made during its lifetime
  * @conn_timeout: the time we can wait for an unresponded setup request
  * @probe_unacked: probe has not received ack yet
-- 
2.34.1
Re: [PATCH] Removed blocking_link field description to prevent kernel doc warning
Posted by Simon Horman 2 years, 4 months ago
On Sun, Mar 03, 2024 at 08:13:59PM +0530, R SUNDAR wrote:
> ./net/tipc/socket.c:143: warning: Excess struct member 'blocking_link' description in 'tipc_sock'
> 
> Signed-off-by: R SUNDAR <prosunofficial@gmail.com>
> ---
>  net/tipc/socket.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/tipc/socket.c b/net/tipc/socket.c
> index bb1118d02f95..7e4135db5816 100644
> --- a/net/tipc/socket.c
> +++ b/net/tipc/socket.c
> @@ -80,7 +80,6 @@ struct sockaddr_pair {
>   * @phdr: preformatted message header used when sending messages
>   * @cong_links: list of congested links
>   * @publications: list of publications for port
> - * @blocking_link: address of the congested link we are currently sleeping on
>   * @pub_count: total # of publications port has made during its lifetime
>   * @conn_timeout: the time we can wait for an unresponded setup request
>   * @probe_unacked: probe has not received ack yet

Thanks, this looks good.
However, it duplicates a patch accepted upstream in January.

Link: https://git.kernel.org/netdev/net-next/c/88bf1b8f3c31

-- 
pw-bot: not-applicable