net/nlmon: Cancel setting filelds of statistics to zero.

[PATCH net-next] net/nlmon: Cancel setting filelds of statistics to zero.

Posted by fuyuanli 1 year, 11 months ago

Since filelds of rtnl_link_stats64 have been set to zero in previous
dev_get_stats function, there is no need to set again in ndo_get_stats64
function.

Signed-off-by: fuyuanli <fuyuanli@didiglobal.com>
---
 drivers/net/nlmon.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/nlmon.c b/drivers/net/nlmon.c
index 5e19a6839dea..9b205b152734 100644
--- a/drivers/net/nlmon.c
+++ b/drivers/net/nlmon.c
@@ -56,10 +56,8 @@ nlmon_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats)
 	dev_lstats_read(dev, &packets, &bytes);
 
 	stats->rx_packets = packets;
-	stats->tx_packets = 0;
 
 	stats->rx_bytes = bytes;
-	stats->tx_bytes = 0;
 }
 
 static u32 always_on(struct net_device *dev)
-- 
2.17.1

Re: [PATCH net-next] net/nlmon: Cancel setting filelds of statistics to zero.

Posted by Jakub Kicinski 1 year, 11 months ago

On Sat, 2 Mar 2024 18:52:24 +0800 fuyuanli wrote:
> Since filelds of rtnl_link_stats64 have been set to zero in previous
> dev_get_stats function, there is no need to set again in ndo_get_stats64
> function.

Please spellcheck the commit msg.
-- 
pw-bot: cr