[PATCH] arm64: dts: qcom: sc7180: Disable pmic pinctrl node on Trogdor

Stephen Boyd posted 1 patch 1 year, 11 months ago
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 +
1 file changed, 1 insertion(+)
[PATCH] arm64: dts: qcom: sc7180: Disable pmic pinctrl node on Trogdor
Posted by Stephen Boyd 1 year, 11 months ago
We don't use this pmic pinctrl node on any Trogdor devices. The
AP_SUSPEND pin is here, but this pinctrl device isn't a supplier to
anything in the devicetrees that include this file. Disable this device
node in the DTS so that we don't waste time or memory on this device.

Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 46aaeba28604..774c0647ea19 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -1164,6 +1164,7 @@ &pm6150_gpios {
 };
 
 &pm6150l_gpios {
+	status = "disabled"; /* No GPIOs are consumed or configured */
 	gpio-line-names = "AP_SUSPEND",
 			  "",
 			  "",

base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
-- 
https://chromeos.dev
Re: [PATCH] arm64: dts: qcom: sc7180: Disable pmic pinctrl node on Trogdor
Posted by Bjorn Andersson 1 year, 10 months ago
On Wed, 28 Feb 2024 17:28:26 -0800, Stephen Boyd wrote:
> We don't use this pmic pinctrl node on any Trogdor devices. The
> AP_SUSPEND pin is here, but this pinctrl device isn't a supplier to
> anything in the devicetrees that include this file. Disable this device
> node in the DTS so that we don't waste time or memory on this device.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sc7180: Disable pmic pinctrl node on Trogdor
      commit: cb69e758d5918cc03e449e159162e263e8bc7ec1

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>
Re: [PATCH] arm64: dts: qcom: sc7180: Disable pmic pinctrl node on Trogdor
Posted by Konrad Dybcio 1 year, 11 months ago

On 2/29/24 02:28, Stephen Boyd wrote:
> We don't use this pmic pinctrl node on any Trogdor devices. The
> AP_SUSPEND pin is here, but this pinctrl device isn't a supplier to
> anything in the devicetrees that include this file. Disable this device
> node in the DTS so that we don't waste time or memory on this device.
> 
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---

If you don't use this pmic, perhaps the pins should be explicitly
"parked" instead?

Konrad
Re: [PATCH] arm64: dts: qcom: sc7180: Disable pmic pinctrl node on Trogdor
Posted by Doug Anderson 1 year, 11 months ago
Hi,

On Wed, Feb 28, 2024 at 5:28 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> We don't use this pmic pinctrl node on any Trogdor devices. The
> AP_SUSPEND pin is here, but this pinctrl device isn't a supplier to
> anything in the devicetrees that include this file. Disable this device
> node in the DTS so that we don't waste time or memory on this device.
>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Douglas Anderson <dianders@chromium.org>