[PATCH] drm/amdgpu: Fix assignment errors in 'si_common_early_init' functions

Lu Yao posted 1 patch 1 year, 11 months ago
drivers/gpu/drm/amd/amdgpu/si.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] drm/amdgpu: Fix assignment errors in 'si_common_early_init' functions
Posted by Lu Yao 1 year, 11 months ago
uvd_ctx_rreg/uvd_ctx_wreg correct value requires function pointer.

Signed-off-by: Lu Yao <yaolu@kylinos.cn>
---
 drivers/gpu/drm/amd/amdgpu/si.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c
index a757526153e5..455d49f7bd9c 100644
--- a/drivers/gpu/drm/amd/amdgpu/si.c
+++ b/drivers/gpu/drm/amd/amdgpu/si.c
@@ -2032,8 +2032,8 @@ static int si_common_early_init(void *handle)
 	adev->pcie_wreg = &si_pcie_wreg;
 	adev->pciep_rreg = &si_pciep_rreg;
 	adev->pciep_wreg = &si_pciep_wreg;
-	adev->uvd_ctx_rreg = si_uvd_ctx_rreg;
-	adev->uvd_ctx_wreg = si_uvd_ctx_wreg;
+	adev->uvd_ctx_rreg = &si_uvd_ctx_rreg;
+	adev->uvd_ctx_wreg = &si_uvd_ctx_wreg;
 	adev->didt_rreg = NULL;
 	adev->didt_wreg = NULL;
 
-- 
2.25.1
Re: [PATCH] drm/amdgpu: Fix assignment errors in 'si_common_early_init' functions
Posted by Christian König 1 year, 11 months ago
Am 28.02.24 um 02:44 schrieb Lu Yao:
> uvd_ctx_rreg/uvd_ctx_wreg correct value requires function pointer.

Yeah, but that is completely irrelevant here. We usually don't use the & 
for function pointers since that is unnecessary in C.

Regards,
Christian.

>
> Signed-off-by: Lu Yao <yaolu@kylinos.cn>
> ---
>   drivers/gpu/drm/amd/amdgpu/si.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c
> index a757526153e5..455d49f7bd9c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/si.c
> +++ b/drivers/gpu/drm/amd/amdgpu/si.c
> @@ -2032,8 +2032,8 @@ static int si_common_early_init(void *handle)
>   	adev->pcie_wreg = &si_pcie_wreg;
>   	adev->pciep_rreg = &si_pciep_rreg;
>   	adev->pciep_wreg = &si_pciep_wreg;
> -	adev->uvd_ctx_rreg = si_uvd_ctx_rreg;
> -	adev->uvd_ctx_wreg = si_uvd_ctx_wreg;
> +	adev->uvd_ctx_rreg = &si_uvd_ctx_rreg;
> +	adev->uvd_ctx_wreg = &si_uvd_ctx_wreg;
>   	adev->didt_rreg = NULL;
>   	adev->didt_wreg = NULL;
>