[v2] Fix defines in rf69.h

[PATCH v2 0/5] Fix defines in rf69.h

Shahar Avidar posted 5 patches 1 year, 11 months ago

Diff against v1 v1
Download series mbox

drivers/staging/pi433/pi433_if.c | 1 +
drivers/staging/pi433/rf69.c     | 4 ++--
drivers/staging/pi433/rf69.h     | 4 ----
3 files changed, 3 insertions(+), 6 deletions(-)

Expand all Fold all

[PATCH v2 0/5] Fix defines in rf69.h

Posted by Shahar Avidar 1 year, 11 months ago

This patchset fixes several misuses of the define statement in rf69.h.
Duplicted defines.
Define in header instead of source file.
Unused define.
Using units.h macro to define frequency.

v2->v1:
- Fix grammer in commit messages.
- Use units.h macro to define frequency.
- Reorder patches to ensure no conflicts.

Shahar Avidar (5):
  staging: pi433: Remove a duplicated FIFO_SIZE define
  staging: pi433: Remove a duplicated F_OSC define
  staging: pi433: Redefine F_OSC using units.h macro
  staging: pi433: Remove the unused FREQUENCY define
  staging: pi433: Move FIFO_THRESHOLD define to source file

 drivers/staging/pi433/pi433_if.c | 1 +
 drivers/staging/pi433/rf69.c     | 4 ++--
 drivers/staging/pi433/rf69.h     | 4 ----
 3 files changed, 3 insertions(+), 6 deletions(-)


base-commit: 455c5e12a3b7d08c2ab47b7dd54944901c69cdcd
-- 
2.34.1

Re: [PATCH v2 0/5] Fix defines in rf69.h

Posted by Andy Shevchenko 1 year, 11 months ago

On Wed, Feb 28, 2024 at 12:11:59AM +0200, Shahar Avidar wrote:
> This patchset fixes several misuses of the define statement in rf69.h.
> Duplicted defines.
> Define in header instead of source file.
> Unused define.
> Using units.h macro to define frequency.

Good enough (esp. for staging),
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

-- 
With Best Regards,
Andy Shevchenko