net: ethernet: adi: move PHYLIB from vendor to driver symbol

[PATCH] net: ethernet: adi: move PHYLIB from vendor to driver symbol

Posted by Randy Dunlap 1 year, 11 months ago

In a previous patch I added "select PHYLIB" at the wrong place for the
ADIN1110 driver symbol, so move it to its correct place under the
ADIN1110 kconfig symbol.

Fixes: a9f80df4f514 ("net: ethernet: adi: requires PHYLIB support")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Michal Kubecek <mkubecek@suse.cz>
Closes: https://lore.kernel.org/lkml/77012b38-4b49-47f4-9a88-d773d52909ad@infradead.org/T/#m8ba397484738711edc0ad607b2c63ca02244e3c3
Cc: Lennart Franzen <lennart@lfdomain.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org
Cc: Nuno Sa <nuno.sa@analog.com>
---
Thanks, Michal.

 drivers/net/ethernet/adi/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/drivers/net/ethernet/adi/Kconfig b/drivers/net/ethernet/adi/Kconfig
--- a/drivers/net/ethernet/adi/Kconfig
+++ b/drivers/net/ethernet/adi/Kconfig
@@ -7,7 +7,6 @@ config NET_VENDOR_ADI
 	bool "Analog Devices devices"
 	default y
 	depends on SPI
-	select PHYLIB
 	help
 	  If you have a network (Ethernet) card belonging to this class, say Y.
 
@@ -22,6 +21,7 @@ config ADIN1110
 	tristate "Analog Devices ADIN1110 MAC-PHY"
 	depends on SPI && NET_SWITCHDEV
 	select CRC8
+	select PHYLIB
 	help
 	  Say yes here to build support for Analog Devices ADIN1110
 	  Low Power 10BASE-T1L Ethernet MAC-PHY.

Re: [PATCH] net: ethernet: adi: move PHYLIB from vendor to driver symbol

Posted by Michal Kubecek 1 year, 11 months ago

On Sun, Feb 25, 2024 at 11:48:20PM -0800, Randy Dunlap wrote:
> In a previous patch I added "select PHYLIB" at the wrong place for the
> ADIN1110 driver symbol, so move it to its correct place under the
> ADIN1110 kconfig symbol.
> 
> Fixes: a9f80df4f514 ("net: ethernet: adi: requires PHYLIB support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Michal Kubecek <mkubecek@suse.cz>
> Closes: https://lore.kernel.org/lkml/77012b38-4b49-47f4-9a88-d773d52909ad@infradead.org/T/#m8ba397484738711edc0ad607b2c63ca02244e3c3
> Cc: Lennart Franzen <lennart@lfdomain.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> Cc: Nuno Sa <nuno.sa@analog.com>

Thank you for the quick update, now the dependencies work as expected.

Tested-by: Michal Kubecek <mkubecek@suse.cz>