MAINTAINERS: Update W's for KEYS/KEYRINGS_INTEGRITY and TPM DEVICE RIVER

[PATCH] MAINTAINERS: Update W's for KEYS/KEYRINGS_INTEGRITY and TPM DEVICE RIVER

Posted by Jarkko Sakkinen 1 year, 11 months ago

Add TPM driver test suite URL to the MAINTAINERS files and move the wiki
URL to more appropriate location.

Link: https://gitlab.com/jarkkojs/linux-tpmdd-test
Link: https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Mimi Zohar <zohar@linux.ibm.com>
Cc: Peter Huewe <peterhuewe@gmx.de>
Cc: linux-integrity@vger.kernel.org
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index bf77be03fb2b..6380c1109b86 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11947,6 +11947,7 @@ M:	Mimi Zohar <zohar@linux.ibm.com>
 L:	linux-integrity@vger.kernel.org
 L:	keyrings@vger.kernel.org
 S:	Supported
+W:	https://kernsec.org/wiki/index.php/inux_Kernel_Integrity
 F:	security/integrity/platform_certs
 
 KFENCE
@@ -22278,7 +22279,7 @@ M:	Jarkko Sakkinen <jarkko@kernel.org>
 R:	Jason Gunthorpe <jgg@ziepe.ca>
 L:	linux-integrity@vger.kernel.org
 S:	Maintained
-W:	https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity
+W:	https://gitlab.com/jarkkojs/linux-tpmdd-test
 Q:	https://patchwork.kernel.org/project/linux-integrity/list/
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git
 F:	drivers/char/tpm/
-- 
2.40.1

Re: [PATCH] MAINTAINERS: Update W's for KEYS/KEYRINGS_INTEGRITY and TPM DEVICE RIVER

Posted by James Bottomley 1 year, 11 months ago

On Mon, 2024-02-26 at 08:22 +0200, Jarkko Sakkinen wrote:
> Add TPM driver test suite URL to the MAINTAINERS files and move the
> wiki
> URL to more appropriate location.
> 
> Link: https://gitlab.com/jarkkojs/linux-tpmdd-test
> Link: https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Mimi Zohar <zohar@linux.ibm.com>
> Cc: Peter Huewe <peterhuewe@gmx.de>
> Cc: linux-integrity@vger.kernel.org
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> ---
>  MAINTAINERS | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index bf77be03fb2b..6380c1109b86 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11947,6 +11947,7 @@ M:      Mimi Zohar <zohar@linux.ibm.com>
>  L:     linux-integrity@vger.kernel.org
>  L:     keyrings@vger.kernel.org
>  S:     Supported
> +W:     https://kernsec.org/wiki/index.php/inux_Kernel_Integrity
                                             ^
                                         Missing L

James

Re: [PATCH] MAINTAINERS: Update W's for KEYS/KEYRINGS_INTEGRITY and TPM DEVICE RIVER

Posted by Jarkko Sakkinen 1 year, 11 months ago

On Mon Feb 26, 2024 at 8:49 AM EET, James Bottomley wrote:
> On Mon, 2024-02-26 at 08:22 +0200, Jarkko Sakkinen wrote:
> > Add TPM driver test suite URL to the MAINTAINERS files and move the
> > wiki
> > URL to more appropriate location.
> > 
> > Link: https://gitlab.com/jarkkojs/linux-tpmdd-test
> > Link: https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity
> > Cc: Jason Gunthorpe <jgg@ziepe.ca>
> > Cc: Mimi Zohar <zohar@linux.ibm.com>
> > Cc: Peter Huewe <peterhuewe@gmx.de>
> > Cc: linux-integrity@vger.kernel.org
> > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> > ---
> >  MAINTAINERS | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index bf77be03fb2b..6380c1109b86 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -11947,6 +11947,7 @@ M:      Mimi Zohar <zohar@linux.ibm.com>
> >  L:     linux-integrity@vger.kernel.org
> >  L:     keyrings@vger.kernel.org
> >  S:     Supported
> > +W:     https://kernsec.org/wiki/index.php/inux_Kernel_Integrity
>                                              ^
>                                          Missing L
>
> James

Thanks! I'll fixup that.

"linux-tpmdd-test" is the suite that I'm using to test your patch set.
It has swtpm integrated. I wonder if there was easy to way to tweak
swtpm to emulate "interposer", i.e. reset its state while it is
running (preferably not by restarting it).

BR, Jarkko

Re: [PATCH] MAINTAINERS: Update W's for KEYS/KEYRINGS_INTEGRITY and TPM DEVICE RIVER

Posted by James Bottomley 1 year, 11 months ago

On Mon, 2024-02-26 at 11:26 +0200, Jarkko Sakkinen wrote:
> On Mon Feb 26, 2024 at 8:49 AM EET, James Bottomley wrote:
> > On Mon, 2024-02-26 at 08:22 +0200, Jarkko Sakkinen wrote:
> > > Add TPM driver test suite URL to the MAINTAINERS files and move
> > > the
> > > wiki
> > > URL to more appropriate location.
> > > 
> > > Link: https://gitlab.com/jarkkojs/linux-tpmdd-test
> > > Link: https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity
> > > Cc: Jason Gunthorpe <jgg@ziepe.ca>
> > > Cc: Mimi Zohar <zohar@linux.ibm.com>
> > > Cc: Peter Huewe <peterhuewe@gmx.de>
> > > Cc: linux-integrity@vger.kernel.org
> > > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> > > ---
> > >  MAINTAINERS | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index bf77be03fb2b..6380c1109b86 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -11947,6 +11947,7 @@ M:      Mimi Zohar <zohar@linux.ibm.com>
> > >  L:     linux-integrity@vger.kernel.org
> > >  L:     keyrings@vger.kernel.org
> > >  S:     Supported
> > > +W:     https://kernsec.org/wiki/index.php/inux_Kernel_Integrity
> >                                              ^
> >                                          Missing L
> > 
> > James
> 
> Thanks! I'll fixup that.
> 
> "linux-tpmdd-test" is the suite that I'm using to test your patch
> set. It has swtpm integrated. I wonder if there was easy to way to
> tweak swtpm to emulate "interposer", i.e. reset its state while it is
> running (preferably not by restarting it).

The way I do it is to use a qemu patch

https://lore.kernel.org/qemu-devel/20231004184219.6594-1-jejb@linux.ibm.com/

which allows qemu to connect to the mssim (or ibmswtpm2) TPM over an
inet socket which means I can execute TPM commands from the host (like
resetting the TPM) as well as the guest and snoop the TPM traffic.

James

Re: [PATCH] MAINTAINERS: Update W's for KEYS/KEYRINGS_INTEGRITY and TPM DEVICE RIVER

Posted by Jarkko Sakkinen 1 year, 11 months ago

On Mon Feb 26, 2024 at 12:11 PM EET, James Bottomley wrote:
> On Mon, 2024-02-26 at 11:26 +0200, Jarkko Sakkinen wrote:
> > On Mon Feb 26, 2024 at 8:49 AM EET, James Bottomley wrote:
> > > On Mon, 2024-02-26 at 08:22 +0200, Jarkko Sakkinen wrote:
> > > > Add TPM driver test suite URL to the MAINTAINERS files and move
> > > > the
> > > > wiki
> > > > URL to more appropriate location.
> > > > 
> > > > Link: https://gitlab.com/jarkkojs/linux-tpmdd-test
> > > > Link: https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity
> > > > Cc: Jason Gunthorpe <jgg@ziepe.ca>
> > > > Cc: Mimi Zohar <zohar@linux.ibm.com>
> > > > Cc: Peter Huewe <peterhuewe@gmx.de>
> > > > Cc: linux-integrity@vger.kernel.org
> > > > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> > > > ---
> > > >  MAINTAINERS | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index bf77be03fb2b..6380c1109b86 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -11947,6 +11947,7 @@ M:      Mimi Zohar <zohar@linux.ibm.com>
> > > >  L:     linux-integrity@vger.kernel.org
> > > >  L:     keyrings@vger.kernel.org
> > > >  S:     Supported
> > > > +W:     https://kernsec.org/wiki/index.php/inux_Kernel_Integrity
> > >                                              ^
> > >                                          Missing L
> > > 
> > > James
> > 
> > Thanks! I'll fixup that.
> > 
> > "linux-tpmdd-test" is the suite that I'm using to test your patch
> > set. It has swtpm integrated. I wonder if there was easy to way to
> > tweak swtpm to emulate "interposer", i.e. reset its state while it is
> > running (preferably not by restarting it).
>
> The way I do it is to use a qemu patch
>
> https://lore.kernel.org/qemu-devel/20231004184219.6594-1-jejb@linux.ibm.com/
>
> which allows qemu to connect to the mssim (or ibmswtpm2) TPM over an
> inet socket which means I can execute TPM commands from the host (like
> resetting the TPM) as well as the guest and snoop the TPM traffic.

To which exact and most recent possible QEMU version I can apply that
cleanly?

My build configuration builds both QEMU and swtpm [1] for every build so
I could pick that patch, copy it to board/qemu/patches/qemu, and set the
version in the BuildRoot configuration appropriately.

[1]
https://gitlab.com/jarkkojs/linux-tpmdd-test/-/tree/main/package/libtpms
https://gitlab.com/jarkkojs/linux-tpmdd-test/-/tree/main/package/swtpm

BR, Jarkko

Re: [PATCH] MAINTAINERS: Update W's for KEYS/KEYRINGS_INTEGRITY and TPM DEVICE RIVER

Posted by Jarkko Sakkinen 1 year, 10 months ago

On Tue Feb 27, 2024 at 8:22 PM EET, Jarkko Sakkinen wrote:
> On Mon Feb 26, 2024 at 12:11 PM EET, James Bottomley wrote:
> > On Mon, 2024-02-26 at 11:26 +0200, Jarkko Sakkinen wrote:
> > > On Mon Feb 26, 2024 at 8:49 AM EET, James Bottomley wrote:
> > > > On Mon, 2024-02-26 at 08:22 +0200, Jarkko Sakkinen wrote:
> > > > > Add TPM driver test suite URL to the MAINTAINERS files and move
> > > > > the
> > > > > wiki
> > > > > URL to more appropriate location.
> > > > > 
> > > > > Link: https://gitlab.com/jarkkojs/linux-tpmdd-test
> > > > > Link: https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity
> > > > > Cc: Jason Gunthorpe <jgg@ziepe.ca>
> > > > > Cc: Mimi Zohar <zohar@linux.ibm.com>
> > > > > Cc: Peter Huewe <peterhuewe@gmx.de>
> > > > > Cc: linux-integrity@vger.kernel.org
> > > > > Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> > > > > ---
> > > > >  MAINTAINERS | 3 ++-
> > > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > index bf77be03fb2b..6380c1109b86 100644
> > > > > --- a/MAINTAINERS
> > > > > +++ b/MAINTAINERS
> > > > > @@ -11947,6 +11947,7 @@ M:      Mimi Zohar <zohar@linux.ibm.com>
> > > > >  L:     linux-integrity@vger.kernel.org
> > > > >  L:     keyrings@vger.kernel.org
> > > > >  S:     Supported
> > > > > +W:     https://kernsec.org/wiki/index.php/inux_Kernel_Integrity
> > > >                                              ^
> > > >                                          Missing L
> > > > 
> > > > James
> > > 
> > > Thanks! I'll fixup that.
> > > 
> > > "linux-tpmdd-test" is the suite that I'm using to test your patch
> > > set. It has swtpm integrated. I wonder if there was easy to way to
> > > tweak swtpm to emulate "interposer", i.e. reset its state while it is
> > > running (preferably not by restarting it).
> >
> > The way I do it is to use a qemu patch
> >
> > https://lore.kernel.org/qemu-devel/20231004184219.6594-1-jejb@linux.ibm.com/
> >
> > which allows qemu to connect to the mssim (or ibmswtpm2) TPM over an
> > inet socket which means I can execute TPM commands from the host (like
> > resetting the TPM) as well as the guest and snoop the TPM traffic.
>
> To which exact and most recent possible QEMU version I can apply that
> cleanly?
>
> My build configuration builds both QEMU and swtpm [1] for every build so
> I could pick that patch, copy it to board/qemu/patches/qemu, and set the
> version in the BuildRoot configuration appropriately.
>
> [1]
> https://gitlab.com/jarkkojs/linux-tpmdd-test/-/tree/main/package/libtpms
> https://gitlab.com/jarkkojs/linux-tpmdd-test/-/tree/main/package/swtpm

Friendly ping. Still looking forward to test.

I cannot recall exact review comments for v7 but what I can recall is
that they were cosmetic.

BR, Jarkko

Re: [PATCH] MAINTAINERS: Update W's for KEYS/KEYRINGS_INTEGRITY and TPM DEVICE RIVER

Posted by Paul Menzel 1 year, 11 months ago

Dear Jarkko,


Thank you for your patch. Two nits:

s/RIVER/DRIVER/

Am 26.02.24 um 07:22 schrieb Jarkko Sakkinen:
> Add TPM driver test suite URL to the MAINTAINERS files and move the wiki

s/files/file/

> URL to more appropriate location.

(Two commits would make the commit message shorter.)

> Link: https://gitlab.com/jarkkojs/linux-tpmdd-test
> Link: https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Mimi Zohar <zohar@linux.ibm.com>
> Cc: Peter Huewe <peterhuewe@gmx.de>
> Cc: linux-integrity@vger.kernel.org
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> ---
>   MAINTAINERS | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index bf77be03fb2b..6380c1109b86 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11947,6 +11947,7 @@ M:	Mimi Zohar <zohar@linux.ibm.com>
>   L:	linux-integrity@vger.kernel.org
>   L:	keyrings@vger.kernel.org
>   S:	Supported
> +W:	https://kernsec.org/wiki/index.php/inux_Kernel_Integrity
>   F:	security/integrity/platform_certs
>   
>   KFENCE
> @@ -22278,7 +22279,7 @@ M:	Jarkko Sakkinen <jarkko@kernel.org>
>   R:	Jason Gunthorpe <jgg@ziepe.ca>
>   L:	linux-integrity@vger.kernel.org
>   S:	Maintained
> -W:	https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity
> +W:	https://gitlab.com/jarkkojs/linux-tpmdd-test
>   Q:	https://patchwork.kernel.org/project/linux-integrity/list/
>   T:	git git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git
>   F:	drivers/char/tpm/

Acked-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul

Re: [PATCH] MAINTAINERS: Update W's for KEYS/KEYRINGS_INTEGRITY and TPM DEVICE RIVER

Posted by Jarkko Sakkinen 1 year, 11 months ago

On Mon Feb 26, 2024 at 8:35 AM EET, Paul Menzel wrote:
> Dear Jarkko,
>
>
> Thank you for your patch. Two nits:
>
> s/RIVER/DRIVER/

lol, thanks for picking up this ;-)

>
> Am 26.02.24 um 07:22 schrieb Jarkko Sakkinen:
> > Add TPM driver test suite URL to the MAINTAINERS files and move the wiki
>
> s/files/file/
>
> > URL to more appropriate location.
>
> (Two commits would make the commit message shorter.)

I think I just remove link-tags as there is not much else than the links
in the actual change (trivial to pick them up from there).

BR, Jarkko