[PATCH 3/4] staging: pi433: Remove a duplicated FIFO_SIZE define

Shahar Avidar posted 4 patches 1 year, 11 months ago
There is a newer version of this series
[PATCH 3/4] staging: pi433: Remove a duplicated FIFO_SIZE define
Posted by Shahar Avidar 1 year, 11 months ago
FIFO_SIZE is being used in both rf69.c & pi433_if.c source files
It is also already defined in rf69.h header file

Signed-off-by: Shahar Avidar <ikobh7@gmail.com>
---
 drivers/staging/pi433/rf69.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index d7e2dbe70d7c..4bfb1a98328f 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -13,7 +13,6 @@
 #include "rf69_registers.h"
 
 #define F_OSC	  32000000 /* Hz */
-#define FIFO_SIZE 66	   /* in byte */
 
 /*-------------------------------------------------------------------------*/
 
-- 
2.34.1
Re: [PATCH 3/4] staging: pi433: Remove a duplicated FIFO_SIZE define
Posted by Andy Shevchenko 1 year, 11 months ago
On Sun, Feb 25, 2024 at 07:33:40PM +0200, Shahar Avidar wrote:
> FIFO_SIZE is being used in both rf69.c & pi433_if.c source files
> It is also already defined in rf69.h header file

You can done this before patch 1, so the code will be cleaner already.

-- 
With Best Regards,
Andy Shevchenko