ubifs: remove SLAB_MEM_SPREAD flag usage

[PATCH] ubifs: remove SLAB_MEM_SPREAD flag usage

Posted by chengming.zhou@linux.dev 1 year, 9 months ago

From: Chengming Zhou <zhouchengming@bytedance.com>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
its usage so we can delete it from slab. No functional change.

Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
---
 fs/ubifs/super.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index f780729eec06..8ae7648021a8 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -2433,8 +2433,8 @@ static int __init ubifs_init(void)
 
 	ubifs_inode_slab = kmem_cache_create("ubifs_inode_slab",
 				sizeof(struct ubifs_inode), 0,
-				SLAB_MEM_SPREAD | SLAB_RECLAIM_ACCOUNT |
-				SLAB_ACCOUNT, &inode_slab_ctor);
+				SLAB_RECLAIM_ACCOUNT | SLAB_ACCOUNT,
+				&inode_slab_ctor);
 	if (!ubifs_inode_slab)
 		return -ENOMEM;
 
-- 
2.40.1

Re: [PATCH] ubifs: remove SLAB_MEM_SPREAD flag usage

Posted by Zhihao Cheng 1 year, 9 months ago

在 2024/2/24 21:52, chengming.zhou@linux.dev 写道:
> From: Chengming Zhou <zhouchengming@bytedance.com>
> 
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
>   fs/ubifs/super.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> index f780729eec06..8ae7648021a8 100644
> --- a/fs/ubifs/super.c
> +++ b/fs/ubifs/super.c
> @@ -2433,8 +2433,8 @@ static int __init ubifs_init(void)
>   
>   	ubifs_inode_slab = kmem_cache_create("ubifs_inode_slab",
>   				sizeof(struct ubifs_inode), 0,
> -				SLAB_MEM_SPREAD | SLAB_RECLAIM_ACCOUNT |
> -				SLAB_ACCOUNT, &inode_slab_ctor);
> +				SLAB_RECLAIM_ACCOUNT | SLAB_ACCOUNT,
> +				&inode_slab_ctor);
>   	if (!ubifs_inode_slab)
>   		return -ENOMEM;
>   
>

Re: [PATCH] ubifs: remove SLAB_MEM_SPREAD flag usage

Posted by Richard Weinberger 1 year, 9 months ago

----- Ursprüngliche Mail -----
> Von: "chengming zhou" <chengming.zhou@linux.dev>
> An: "richard" <richard@nod.at>
> CC: "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, "linux-mm"
> <linux-mm@kvack.org>, vbabka@suse.cz, "roman gushchin" <roman.gushchin@linux.dev>, "Xiongwei Song"
> <Xiongwei.Song@windriver.com>, "chengming zhou" <chengming.zhou@linux.dev>, "Chengming Zhou"
> <zhouchengming@bytedance.com>
> Gesendet: Samstag, 24. Februar 2024 14:52:17
> Betreff: [PATCH] ubifs: remove SLAB_MEM_SPREAD flag usage

> From: Chengming Zhou <zhouchengming@bytedance.com>
> 
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>

Applied.
Next time please add a reference that makes very clear why such a flag
is no longer needed.
It took me a few minutes to figure why SLAB_MEM_SPREAD is
now a no-op.

Thanks,
//richard

Re: [PATCH] ubifs: remove SLAB_MEM_SPREAD flag usage

Posted by Chengming Zhou 1 year, 9 months ago

On 2024/2/26 04:36, Richard Weinberger wrote:
> ----- Ursprüngliche Mail -----
>> Von: "chengming zhou" <chengming.zhou@linux.dev>
>> An: "richard" <richard@nod.at>
>> CC: "linux-mtd" <linux-mtd@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org>, "linux-mm"
>> <linux-mm@kvack.org>, vbabka@suse.cz, "roman gushchin" <roman.gushchin@linux.dev>, "Xiongwei Song"
>> <Xiongwei.Song@windriver.com>, "chengming zhou" <chengming.zhou@linux.dev>, "Chengming Zhou"
>> <zhouchengming@bytedance.com>
>> Gesendet: Samstag, 24. Februar 2024 14:52:17
>> Betreff: [PATCH] ubifs: remove SLAB_MEM_SPREAD flag usage
> 
>> From: Chengming Zhou <zhouchengming@bytedance.com>
>>
>> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
>> its usage so we can delete it from slab. No functional change.
>>
>> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> 
> Applied.
> Next time please add a reference that makes very clear why such a flag
> is no longer needed.
> It took me a few minutes to figure why SLAB_MEM_SPREAD is
> now a no-op.

Update changelog to make it clearer:

The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag. And the series[1]
went on to mark it obsolete to avoid confusion for users. Here we
can just remove all its users, which has no functional change.

[1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/

Thanks!

> 
> Thanks,
> //richard