freevxfs: remove SLAB_MEM_SPREAD flag usage

[PATCH] freevxfs: remove SLAB_MEM_SPREAD flag usage

Posted by chengming.zhou@linux.dev 1 year, 9 months ago

From: Chengming Zhou <zhouchengming@bytedance.com>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
its usage so we can delete it from slab. No functional change.

Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
---
 fs/freevxfs/vxfs_super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/freevxfs/vxfs_super.c b/fs/freevxfs/vxfs_super.c
index e6e2a2185e7c..42e03b6b1cc7 100644
--- a/fs/freevxfs/vxfs_super.c
+++ b/fs/freevxfs/vxfs_super.c
@@ -307,7 +307,7 @@ vxfs_init(void)
 
 	vxfs_inode_cachep = kmem_cache_create_usercopy("vxfs_inode",
 			sizeof(struct vxfs_inode_info), 0,
-			SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD,
+			SLAB_RECLAIM_ACCOUNT,
 			offsetof(struct vxfs_inode_info, vii_immed.vi_immed),
 			sizeof_field(struct vxfs_inode_info,
 				vii_immed.vi_immed),
-- 
2.40.1

Re: [PATCH] freevxfs: remove SLAB_MEM_SPREAD flag usage

Posted by Christoph Hellwig 1 year, 9 months ago

Please just do a scripted removal after next -rc1 instead of spamming
everyone..

Re: [PATCH] freevxfs: remove SLAB_MEM_SPREAD flag usage

Posted by Chengming Zhou 1 year, 9 months ago

On 2024/2/26 18:06, Christoph Hellwig wrote:
> Please just do a scripted removal after next -rc1 instead of spamming
> everyone..
> 
Do you mean put all diffs into a single patch, send it to all people?
That is also a choice if it's preferable. Should it will go through
the slab tree then?

Thanks.

Re: [PATCH] freevxfs: remove SLAB_MEM_SPREAD flag usage

Posted by Christoph Hellwig 1 year, 9 months ago

On Mon, Feb 26, 2024 at 06:24:32PM +0800, Chengming Zhou wrote:
> On 2024/2/26 18:06, Christoph Hellwig wrote:
> > Please just do a scripted removal after next -rc1 instead of spamming
> > everyone..
> > 
> Do you mean put all diffs into a single patch, send it to all people?
> That is also a choice if it's preferable. Should it will go through
> the slab tree then?

Yes, send a scripted removal of what is left after6.9 -rc1 either to the
slab maintainers or directly to Linus with the slab maintainers ACK.

Re: [PATCH] freevxfs: remove SLAB_MEM_SPREAD flag usage

Posted by Vlastimil Babka 1 year, 9 months ago

On 2/26/24 11:24, Chengming Zhou wrote:
> On 2024/2/26 18:06, Christoph Hellwig wrote:
>> Please just do a scripted removal after next -rc1 instead of spamming
>> everyone..
>> 
> Do you mean put all diffs into a single patch, send it to all people?
> That is also a choice if it's preferable. Should it will go through
> the slab tree then?

In case that's what Christoph means, we should exclude from that those
subsystems that already took your patches.

> Thanks.