ext2: remove SLAB_MEM_SPREAD flag usage

[PATCH] ext2: remove SLAB_MEM_SPREAD flag usage

Posted by chengming.zhou@linux.dev 1 year, 9 months ago

From: Chengming Zhou <zhouchengming@bytedance.com>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
its usage so we can delete it from slab. No functional change.

Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
---
 fs/ext2/super.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 6d8587505cea..7162c61c0402 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -213,8 +213,7 @@ static int __init init_inodecache(void)
 {
 	ext2_inode_cachep = kmem_cache_create_usercopy("ext2_inode_cache",
 				sizeof(struct ext2_inode_info), 0,
-				(SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD|
-					SLAB_ACCOUNT),
+				SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT,
 				offsetof(struct ext2_inode_info, i_data),
 				sizeof_field(struct ext2_inode_info, i_data),
 				init_once);
-- 
2.40.1

Re: [PATCH] ext2: remove SLAB_MEM_SPREAD flag usage

Posted by Jan Kara 1 year, 9 months ago

On Sat 24-02-24 13:48:16, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
> 
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>

Thanks. I've added the patch to my tree.

								Honza

> ---
>  fs/ext2/super.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 6d8587505cea..7162c61c0402 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -213,8 +213,7 @@ static int __init init_inodecache(void)
>  {
>  	ext2_inode_cachep = kmem_cache_create_usercopy("ext2_inode_cache",
>  				sizeof(struct ext2_inode_info), 0,
> -				(SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD|
> -					SLAB_ACCOUNT),
> +				SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT,
>  				offsetof(struct ext2_inode_info, i_data),
>  				sizeof_field(struct ext2_inode_info, i_data),
>  				init_once);
> -- 
> 2.40.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR