Fix MMC/GPIO regression on Nokia N8x0

[PATCH 0/5] Fix MMC/GPIO regression on Nokia N8x0

Posted by Aaro Koskinen 1 year, 11 months ago

Hi,

Nokia N8x0 MMC has been pretty much broken starting from v6.3. These
patches restore the functionality. Tested on N810 with eMMC and external
miniSD card, and on N800 with SD card in the inner slot.

A.

Aaro Koskinen (5):
  ARM: OMAP: fix bogus MMC GPIO labels on Nokia N8x0
  ARM: OMAP: fix N810 MMC gpiod table
  MMC: OMAP: fix broken slot switch lookup
  MMC: OMAP: fix deferred probe
  MMC: OMAP: restore original power up/down steps

 arch/arm/mach-omap2/board-n8x0.c | 17 ++++++-----
 drivers/mmc/host/omap.c          | 48 +++++++++++++++++++++-----------
 2 files changed, 39 insertions(+), 26 deletions(-)

-- 
2.39.2

Re: [PATCH 0/5] Fix MMC/GPIO regression on Nokia N8x0

Posted by Linus Walleij 1 year, 11 months ago

On Fri, Feb 23, 2024 at 7:15 PM Aaro Koskinen <aaro.koskinen@iki.fi> wrote:

> Nokia N8x0 MMC has been pretty much broken starting from v6.3. These
> patches restore the functionality. Tested on N810 with eMMC and external
> miniSD card, and on N800 with SD card in the inner slot.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

100% my fault, I'm sorry I couldn't dry-code any better :(

If it's any consolation, there are now no GPIOs left for me to break
on the Nokia N8xx:s.

Yours,
Linus Walleij

Re: [PATCH 0/5] Fix MMC/GPIO regression on Nokia N8x0

Posted by Tony Lindgren 1 year, 11 months ago

* Linus Walleij <linus.walleij@linaro.org> [240223 20:47]:
> On Fri, Feb 23, 2024 at 7:15 PM Aaro Koskinen <aaro.koskinen@iki.fi> wrote:
> 
> > Nokia N8x0 MMC has been pretty much broken starting from v6.3. These
> > patches restore the functionality. Tested on N810 with eMMC and external
> > miniSD card, and on N800 with SD card in the inner slot.
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> 100% my fault, I'm sorry I couldn't dry-code any better :(
> 
> If it's any consolation, there are now no GPIOs left for me to break
> on the Nokia N8xx:s.

That's the two-step conversion by introducing bugs first :)

Maybe Ulf can ack the mmc patches and I'll apply these all into a
fixes branch.

Regards,

Tony

Re: [PATCH 0/5] Fix MMC/GPIO regression on Nokia N8x0

Posted by Ulf Hansson 1 year, 11 months ago

On Fri, 23 Feb 2024 at 19:15, Aaro Koskinen <aaro.koskinen@iki.fi> wrote:
>
> Hi,
>
> Nokia N8x0 MMC has been pretty much broken starting from v6.3. These
> patches restore the functionality. Tested on N810 with eMMC and external
> miniSD card, and on N800 with SD card in the inner slot.
>
> A.
>
> Aaro Koskinen (5):
>   ARM: OMAP: fix bogus MMC GPIO labels on Nokia N8x0
>   ARM: OMAP: fix N810 MMC gpiod table
>   MMC: OMAP: fix broken slot switch lookup
>   MMC: OMAP: fix deferred probe
>   MMC: OMAP: restore original power up/down steps
>
>  arch/arm/mach-omap2/board-n8x0.c | 17 ++++++-----
>  drivers/mmc/host/omap.c          | 48 +++++++++++++++++++++-----------
>  2 files changed, 39 insertions(+), 26 deletions(-)
>

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Nitpick: Tony, while applying I think it would be nice to change the
prefixes of the commit message headers for the mmc patches to "mmc:
omap:".

Kind regards
Uffe