[v1] tracing: Add warning if string in __assign_str() does not match __string()

[PATCH] tracing: Add warning if string in __assign_str() does not match __string()

Steven Rostedt posted 1 patch 1 year, 11 months ago

Diff against v2
Download mbox

There is a newer version of this series

include/trace/stages/stage6_event_callback.h | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] tracing: Add warning if string in __assign_str() does not match __string()

Posted by Steven Rostedt 1 year, 11 months ago

From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

In preparation to remove the second parameter of __assign_str(), make sure
it is really a duplicate of __string() by adding a WARN_ON_ONCE().

Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 include/trace/stages/stage6_event_callback.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/trace/stages/stage6_event_callback.h b/include/trace/stages/stage6_event_callback.h
index 0c0f50bcdc56..7372e2c2a0c4 100644
--- a/include/trace/stages/stage6_event_callback.h
+++ b/include/trace/stages/stage6_event_callback.h
@@ -35,6 +35,7 @@
 	do {								\
 		char *__str__ = __get_str(dst);				\
 		int __len__ = __get_dynamic_array_len(dst) - 1;		\
+		WARN_ON_ONCE((src) && (src) != __data_offsets.dst##_ptr_); \
 		memcpy(__str__, __data_offsets.dst##_ptr_ ? :		\
 		       EVENT_NULL_STR, __len__);			\
 		__str__[__len__] = '\0';				\
-- 
2.43.0