[v1] net: phy: dp83826: disable WOL at init

[PATCH] net: phy: dp83826: disable WOL at init

Posted by Catalin Popescu 1 year, 11 months ago

Commit d1d77120bc28 ("net: phy: dp83826: support TX data voltage tuning")
introduced a regression in that WOL is not disabled by default for DP83826.
WOL should normally be enabled through ethtool.

Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
---
 drivers/net/phy/dp83822.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
index 30f2616ab1c2..ba320dc3df98 100644
--- a/drivers/net/phy/dp83822.c
+++ b/drivers/net/phy/dp83822.c
@@ -528,7 +528,7 @@ static int dp83826_config_init(struct phy_device *phydev)
 			return ret;
 	}
 
-	return 0;
+	return dp8382x_disable_wol(phydev);
 }
 
 static int dp8382x_config_init(struct phy_device *phydev)

base-commit: 33e1d31873f87d119e5120b88cd350efa68ef276
-- 
2.34.1

Re: [PATCH] net: phy: dp83826: disable WOL at init

Posted by Andrew Lunn 1 year, 11 months ago

On Fri, Feb 23, 2024 at 03:31:27PM +0100, Catalin Popescu wrote:
> Commit d1d77120bc28 ("net: phy: dp83826: support TX data voltage tuning")
> introduced a regression in that WOL is not disabled by default for DP83826.
> WOL should normally be enabled through ethtool.
> 
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>

d1d77120bc28 ("net: phy: dp83826: support TX data voltage tuning") is
only in net-next? So you should set the patch subject to
net-next. See:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq

Please also add a Fixes tag.

The change itself looks O.K.

       Andrew