[PATCH net-next v5 2/7] dt-bindings: net: hisilicon,hisi-femac-mdio: remove clocks

Yang Xiwen via B4 Relay posted 7 patches 1 year, 11 months ago
There is a newer version of this series
[PATCH net-next v5 2/7] dt-bindings: net: hisilicon,hisi-femac-mdio: remove clocks
Posted by Yang Xiwen via B4 Relay 1 year, 11 months ago
From: Yang Xiwen <forbidden405@outlook.com>

This integrated MDIO bus does have a dedicated clock. Remove it. The old
binding is wrong.

Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
---
 Documentation/devicetree/bindings/net/hisilicon,hisi-femac-mdio.yaml | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/hisilicon,hisi-femac-mdio.yaml b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac-mdio.yaml
index 36def9d5eecd..dea1bcc27381 100644
--- a/Documentation/devicetree/bindings/net/hisilicon,hisi-femac-mdio.yaml
+++ b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac-mdio.yaml
@@ -19,13 +19,9 @@ properties:
   reg:
     maxItems: 1
 
-  clocks:
-    maxItems: 1
-
 required:
   - compatible
   - reg
-  - clocks
 
 unevaluatedProperties: false
 
@@ -34,7 +30,6 @@ examples:
     mdio@10091100 {
         compatible = "hisilicon,hisi-femac-mdio";
         reg = <0x10091100 0x20>;
-        clocks = <&clk_mdio>;
         #address-cells = <1>;
         #size-cells = <0>;
 

-- 
2.43.0
Re: [PATCH net-next v5 2/7] dt-bindings: net: hisilicon,hisi-femac-mdio: remove clocks
Posted by Andrew Lunn 1 year, 11 months ago
On Fri, Feb 23, 2024 at 09:28:17PM +0800, Yang Xiwen via B4 Relay wrote:
> From: Yang Xiwen <forbidden405@outlook.com>
> 
> This integrated MDIO bus does have a dedicated clock. Remove it. The old

I think you are missing a 'not' in that sentence.

  Andrew
Re: [PATCH net-next v5 2/7] dt-bindings: net: hisilicon,hisi-femac-mdio: remove clocks
Posted by Krzysztof Kozlowski 1 year, 11 months ago
On 23/02/2024 14:28, Yang Xiwen via B4 Relay wrote:
> From: Yang Xiwen <forbidden405@outlook.com>
> 
> This integrated MDIO bus does have a dedicated clock. Remove it. The old
> binding is wrong.
> 
> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>

Slow down with your patches... Multiple series every day is a bit too
much. Or help reducing the burden and review other people's work.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof