[PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding

Conor Dooley posted 5 patches 1 year, 11 months ago
[PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding
Posted by Conor Dooley 1 year, 11 months ago
From: Conor Dooley <conor.dooley@microchip.com>

These devices are regulators may need to make use of the common
regulator properties, but these are not permitted while only documented
in trivial-devices.yaml

Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 .../bindings/regulator/infineon,ir38060.yaml  | 46 +++++++++++++++++++
 .../devicetree/bindings/trivial-devices.yaml  |  8 ----
 2 files changed, 46 insertions(+), 8 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml

diff --git a/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml b/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
new file mode 100644
index 000000000000..bb0114f7e13f
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/infineon,ir38060.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Infineon Buck Regulators with PMBUS interfaces
+
+maintainers:
+  - Not Me.
+
+allOf:
+  - $ref: regulator.yaml#
+
+properties:
+  compatible:
+    enum:
+      - infineon,ir38060
+      - infineon,ir38064
+      - infineon,ir38164
+      - infineon,ir38263
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      regulator@34 {
+        compatible = "infineon,ir38060";
+        reg = <0x34>;
+
+        regulator-min-microvolt = <437500>;
+        regulator-max-microvolt = <1387500>;
+      };
+    };
+
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 9cdd5a534120..e07be7bf8395 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -130,14 +130,6 @@ properties:
           - infineon,dps310
             # Infineon IR36021 digital POL buck controller
           - infineon,ir36021
-            # Infineon IR38060 Voltage Regulator
-          - infineon,ir38060
-            # Infineon IR38064 Voltage Regulator
-          - infineon,ir38064
-            # Infineon IR38164 Voltage Regulator
-          - infineon,ir38164
-            # Infineon IR38263 Voltage Regulator
-          - infineon,ir38263
             # Infineon IRPS5401 Voltage Regulator (PMIC)
           - infineon,irps5401
             # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor
-- 
2.43.0
Re: [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding
Posted by Geert Uytterhoeven 10 months ago
Hi Conor,

On Fri, 23 Feb 2024 at 17:23, Conor Dooley <conor@kernel.org> wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> These devices are regulators may need to make use of the common
> regulator properties, but these are not permitted while only documented
> in trivial-devices.yaml
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>

Thanks for your patch, which is now commit bad582f9879812bc
("regulator: dt-bindings: promote infineon buck converters
to their own binding") in v6.9-rc1.

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/infineon,ir38060.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Infineon Buck Regulators with PMBUS interfaces
> +
> +maintainers:
> +  - Not Me.

make dt_binding_check:

    Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml:
maintainers:0: 'Not Me.' does not match '@'
            from schema $id: http://devicetree.org/meta-schemas/base.yaml#

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Re: [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding
Posted by Conor Dooley 10 months ago
On Thu, Apr 10, 2025 at 06:15:24PM +0200, Geert Uytterhoeven wrote:
> Hi Conor,
> 
> On Fri, 23 Feb 2024 at 17:23, Conor Dooley <conor@kernel.org> wrote:
> > From: Conor Dooley <conor.dooley@microchip.com>
> >
> > These devices are regulators may need to make use of the common
> > regulator properties, but these are not permitted while only documented
> > in trivial-devices.yaml
> >
> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Thanks for your patch, which is now commit bad582f9879812bc
> ("regulator: dt-bindings: promote infineon buck converters
> to their own binding") in v6.9-rc1.
> 
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
> > @@ -0,0 +1,46 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/regulator/infineon,ir38060.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Infineon Buck Regulators with PMBUS interfaces
> > +
> > +maintainers:
> > +  - Not Me.
> 
> make dt_binding_check:
> 
>     Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml:
> maintainers:0: 'Not Me.' does not match '@'
>             from schema $id: http://devicetree.org/meta-schemas/base.yaml#

Yup, and it is still "Not Me.". Shouldn't have been merged in the first
place (or sent tbh), but someone who understands and cares for it should
be here (Not me!)
Re: [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding
Posted by Conor Dooley 10 months ago
+CC Naresh

On Fri, Apr 11, 2025 at 05:46:38PM +0100, Conor Dooley wrote:
> On Thu, Apr 10, 2025 at 06:15:24PM +0200, Geert Uytterhoeven wrote:
> > Hi Conor,
> > 
> > On Fri, 23 Feb 2024 at 17:23, Conor Dooley <conor@kernel.org> wrote:
> > > From: Conor Dooley <conor.dooley@microchip.com>
> > >
> > > These devices are regulators may need to make use of the common
> > > regulator properties, but these are not permitted while only documented
> > > in trivial-devices.yaml
> > >
> > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> > 
> > Thanks for your patch, which is now commit bad582f9879812bc
> > ("regulator: dt-bindings: promote infineon buck converters
> > to their own binding") in v6.9-rc1.
> > 
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml
> > > @@ -0,0 +1,46 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/regulator/infineon,ir38060.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Infineon Buck Regulators with PMBUS interfaces
> > > +
> > > +maintainers:
> > > +  - Not Me.
> > 
> > make dt_binding_check:
> > 
> >     Documentation/devicetree/bindings/regulator/infineon,ir38060.yaml:
> > maintainers:0: 'Not Me.' does not match '@'
> >             from schema $id: http://devicetree.org/meta-schemas/base.yaml#
> 
> Yup, and it is still "Not Me.". Shouldn't have been merged in the first
> place (or sent tbh), but someone who understands and cares for it should
> be here (Not me!)

You want to put your name down for this one Naresh, you're the one
making changes to the binding etc so actually know how it works?


Re: [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding
Posted by Mark Brown 1 year, 11 months ago
On Fri, Feb 23, 2024 at 04:21:06PM +0000, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> These devices are regulators may need to make use of the common
> regulator properties, but these are not permitted while only documented
> in trivial-devices.yaml

Reviewed-by: Mark Brown <broonie@kernel.org>
Re: [PATCH v2 2/5] regulator: dt-bindings: promote infineon buck converters to their own binding
Posted by Krzysztof Kozlowski 1 year, 11 months ago
On 23/02/2024 17:21, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> These devices are regulators may need to make use of the common
> regulator properties, but these are not permitted while only documented
> in trivial-devices.yaml
> 
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof