mfd: twl: select MFD_CORE

[PATCH] mfd: twl: select MFD_CORE

Posted by A. Sverdlin 1 year, 11 months ago

From: Alexander Sverdlin <alexander.sverdlin@siemens.com>

Fix link error:
ld.bfd: drivers/mfd/twl-core.o: in function `twl_probe':
git/drivers/mfd/twl-core.c:846: undefined reference to `devm_mfd_add_devices'

Cc: <stable@vger.kernel.org>
Fixes: 63416320419e ("mfd: twl-core: Add a clock subdevice for the TWL6032")
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
---
 drivers/mfd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 90ce58fd629e5..1195a27c881e4 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1772,6 +1772,7 @@ config TWL4030_CORE
 	bool "TI TWL4030/TWL5030/TWL6030/TPS659x0 Support"
 	depends on I2C=y
 	select IRQ_DOMAIN
+	select MFD_CORE
 	select REGMAP_I2C
 	help
 	  Say yes here if you have TWL4030 / TWL6030 family chip on your board.
-- 
2.43.0

Re: (subset) [PATCH] mfd: twl: select MFD_CORE

Posted by Lee Jones 1 year, 11 months ago

On Wed, 21 Feb 2024 15:30:18 +0100, A. Sverdlin wrote:
> Fix link error:
> ld.bfd: drivers/mfd/twl-core.o: in function `twl_probe':
> git/drivers/mfd/twl-core.c:846: undefined reference to `devm_mfd_add_devices'
> 
> 

Applied, thanks!

[1/1] mfd: twl: select MFD_CORE
      commit: 3bb36528d46e494987ee5e9682d08318928ae041

--
Lee Jones [李琼斯]

Re: [PATCH] mfd: twl: select MFD_CORE

Posted by Andreas Kemnade 1 year, 11 months ago

On Wed, 21 Feb 2024 15:30:18 +0100
"A. Sverdlin" <alexander.sverdlin@siemens.com> wrote:

> From: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> 
> Fix link error:
> ld.bfd: drivers/mfd/twl-core.o: in function `twl_probe':
> git/drivers/mfd/twl-core.c:846: undefined reference to `devm_mfd_add_devices'
> 
> Cc: <stable@vger.kernel.org>
> Fixes: 63416320419e ("mfd: twl-core: Add a clock subdevice for the TWL6032")
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>

oops, sorry, thought it would be enabled if any mfd thing is compiled... but
it is not
so,

Reviewed-by: Andreas Kemnade <andreas@kemnade.info>