[PATCH] firmware_loader: Suppress warning on FW_OPT_NO_WARN flag

Mukesh Ojha posted 1 patch 1 year, 11 months ago
drivers/base/firmware_loader/main.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
[PATCH] firmware_loader: Suppress warning on FW_OPT_NO_WARN flag
Posted by Mukesh Ojha 1 year, 11 months ago
Some of the warnings are still being printed even if FW_OPT_NO_WARN
is passed for some of the function e.g., firmware_request_nowarn().
Fix it by adding a check for FW_OPT_NO_WARN before printing the warning.

Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
---
 drivers/base/firmware_loader/main.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
index ea28102d421e..da8ca01d011c 100644
--- a/drivers/base/firmware_loader/main.c
+++ b/drivers/base/firmware_loader/main.c
@@ -551,12 +551,16 @@ fw_get_filesystem_firmware(struct device *device, struct fw_priv *fw_priv,
 						       file_size_ptr,
 						       READING_FIRMWARE);
 		if (rc < 0) {
-			if (rc != -ENOENT)
-				dev_warn(device, "loading %s failed with error %d\n",
-					 path, rc);
-			else
-				dev_dbg(device, "loading %s failed for no such file or directory.\n",
-					 path);
+			if (!(fw_priv->opt_flags & FW_OPT_NO_WARN)) {
+				if (rc != -ENOENT)
+					dev_warn(device,
+						 "loading %s failed with error %d\n",
+						 path, rc);
+				else
+					dev_dbg(device,
+						"loading %s failed for no such file or directory.\n",
+						path);
+			}
 			continue;
 		}
 		size = rc;
-- 
2.43.0.254.ga26002b62827
Re: [PATCH] firmware_loader: Suppress warning on FW_OPT_NO_WARN flag
Posted by Luis Chamberlain 1 year, 11 months ago
On Mon, Feb 19, 2024 at 10:09:54PM +0530, Mukesh Ojha wrote:
> Some of the warnings are still being printed even if FW_OPT_NO_WARN
> is passed for some of the function e.g., firmware_request_nowarn().
> Fix it by adding a check for FW_OPT_NO_WARN before printing the warning.
> 
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>

Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>

  Luis