kbuild: rust: use `-Zdebuginfo-compression`

[PATCH] kbuild: rust: use `-Zdebuginfo-compression`

Posted by Miguel Ojeda 1 year, 11 months ago

Rust 1.74.0 introduced (unstable) support for the
`-Zdebuginfo-compression` flag, thus use it.

Link: https://github.com/rust-lang/rust/issues/120953
Link: https://github.com/rust-lang/rust/pull/115358
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
 scripts/Makefile.debug | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/Makefile.debug b/scripts/Makefile.debug
index 059ff38fe0cb..1f96af51f936 100644
--- a/scripts/Makefile.debug
+++ b/scripts/Makefile.debug
@@ -29,10 +29,12 @@ endif
 
 ifdef CONFIG_DEBUG_INFO_COMPRESSED_ZLIB
 DEBUG_CFLAGS	+= -gz=zlib
+DEBUG_RUSTFLAGS	+= -Zdebuginfo-compression=zlib
 KBUILD_AFLAGS	+= -gz=zlib
 KBUILD_LDFLAGS	+= --compress-debug-sections=zlib
 else ifdef CONFIG_DEBUG_INFO_COMPRESSED_ZSTD
 DEBUG_CFLAGS	+= -gz=zstd
+DEBUG_RUSTFLAGS	+= -Zdebuginfo-compression=zstd
 KBUILD_AFLAGS	+= -gz=zstd
 KBUILD_LDFLAGS	+= --compress-debug-sections=zstd
 endif

base-commit: 841c35169323cd833294798e58b9bf63fa4fa1de
-- 
2.43.0

Re: [PATCH] kbuild: rust: use `-Zdebuginfo-compression`

Posted by Alice Ryhl 1 year, 10 months ago

On Sat, Feb 17, 2024 at 1:26 AM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> Rust 1.74.0 introduced (unstable) support for the
> `-Zdebuginfo-compression` flag, thus use it.
>
> Link: https://github.com/rust-lang/rust/issues/120953
> Link: https://github.com/rust-lang/rust/pull/115358
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

Re: [PATCH] kbuild: rust: use `-Zdebuginfo-compression`

Posted by Miguel Ojeda 1 year, 10 months ago

On Sat, Feb 17, 2024 at 1:26 AM Miguel Ojeda <ojeda@kernel.org> wrote:
>
> Rust 1.74.0 introduced (unstable) support for the
> `-Zdebuginfo-compression` flag, thus use it.
>
> Link: https://github.com/rust-lang/rust/issues/120953
> Link: https://github.com/rust-lang/rust/pull/115358
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

[ Added note about zstd support in Rust-provided binaries. ]

Applied to `rust-next` -- please feel free to still send reviews or
tested-bys for this one!

Cheers,
Miguel