[v2] Fix PHY init timeout issues

[PATCH v2 0/2] Fix PHY init timeout issues

Elad Nachman posted 2 patches 1 year, 2 months ago

Diff against v1 v3
Download series mbox

There is a newer version of this series

drivers/mmc/host/sdhci-xenon-phy.c | 48 ++++++++++++++++++++++++------
1 file changed, 39 insertions(+), 9 deletions(-)

Expand all Fold all

[PATCH v2 0/2] Fix PHY init timeout issues

Posted by Elad Nachman 1 year, 2 months ago

From: Elad Nachman <enachman@marvell.com>

Fix PHY init timeout issues:

1. Clock Stability issue causing PHY timeout

2. Timeout taking longer than needed on AC5X.
   Solve by constantly testing the PHY init bit
   until it toggles, but up to 100X timeout factor.

v2:
    1) convert polling loop to read_poll_timeout()
       for both patches.

Elad Nachman (2):
  mmc: xenon: fix PHY init clock stability
  mmc: xenon: add timeout for PHY init complete

 drivers/mmc/host/sdhci-xenon-phy.c | 48 ++++++++++++++++++++++++------
 1 file changed, 39 insertions(+), 9 deletions(-)

-- 
2.25.1

Re: [PATCH v2 0/2] Fix PHY init timeout issues

Posted by Ulf Hansson 1 year, 2 months ago

On Thu, 15 Feb 2024 at 17:16, Elad Nachman <enachman@marvell.com> wrote:
>
> From: Elad Nachman <enachman@marvell.com>
>
> Fix PHY init timeout issues:
>
> 1. Clock Stability issue causing PHY timeout
>
> 2. Timeout taking longer than needed on AC5X.
>    Solve by constantly testing the PHY init bit
>    until it toggles, but up to 100X timeout factor.
>
> v2:
>     1) convert polling loop to read_poll_timeout()
>        for both patches.
>
> Elad Nachman (2):
>   mmc: xenon: fix PHY init clock stability
>   mmc: xenon: add timeout for PHY init complete
>
>  drivers/mmc/host/sdhci-xenon-phy.c | 48 ++++++++++++++++++++++++------
>  1 file changed, 39 insertions(+), 9 deletions(-)
>

The series looks good to me. Although, I assume we should tag this for
stable kernels too and possibly add a fixes tag?

Moreover, it would be nice to get an ack from Hu Ziji.

Kind regards
Uffe