arm64: dts: ti: k3-am654: Drop ti,syscon-rgmii-delay from ICSSG nodes

[PATCH] arm64: dts: ti: k3-am654: Drop ti,syscon-rgmii-delay from ICSSG nodes

Posted by MD Danish Anwar 1 year, 11 months ago

Drop ti,syscon-rgmii-delay from ICSSG0, ICSSG1 and ICSSG2 node as this
property is no longer used by ICSSG driver.

Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 2 --
 arch/arm64/boot/dts/ti/k3-am654-idk.dtso    | 4 ----
 2 files changed, 6 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso b/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso
index 0a6e75265ba9..bb0e29873df7 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso
+++ b/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso
@@ -68,7 +68,6 @@ icssg2_emac0: port@0 {
 				reg = <0>;
 				phy-handle = <&icssg2_phy0>;
 				phy-mode = "rgmii-id";
-				ti,syscon-rgmii-delay = <&scm_conf 0x4120>;
 				/* Filled in by bootloader */
 				local-mac-address = [00 00 00 00 00 00];
 			};
@@ -76,7 +75,6 @@ icssg2_emac1: port@1 {
 				reg = <1>;
 				phy-handle = <&icssg2_phy1>;
 				phy-mode = "rgmii-id";
-				ti,syscon-rgmii-delay = <&scm_conf 0x4124>;
 				/* Filled in by bootloader */
 				local-mac-address = [00 00 00 00 00 00];
 			};
diff --git a/arch/arm64/boot/dts/ti/k3-am654-idk.dtso b/arch/arm64/boot/dts/ti/k3-am654-idk.dtso
index 8bdb87fcbde0..d4bc80032587 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-idk.dtso
+++ b/arch/arm64/boot/dts/ti/k3-am654-idk.dtso
@@ -72,7 +72,6 @@ icssg0_emac0: port@0 {
 				reg = <0>;
 				phy-handle = <&icssg0_phy0>;
 				phy-mode = "rgmii-id";
-				ti,syscon-rgmii-delay = <&scm_conf 0x4100>;
 				/* Filled in by bootloader */
 				local-mac-address = [00 00 00 00 00 00];
 			};
@@ -80,7 +79,6 @@ icssg0_emac1: port@1 {
 				reg = <1>;
 				phy-handle = <&icssg0_phy1>;
 				phy-mode = "rgmii-id";
-				ti,syscon-rgmii-delay = <&scm_conf 0x4104>;
 				/* Filled in by bootloader */
 				local-mac-address = [00 00 00 00 00 00];
 			};
@@ -140,7 +138,6 @@ icssg1_emac0: port@0 {
 				reg = <0>;
 				phy-handle = <&icssg1_phy0>;
 				phy-mode = "rgmii-id";
-				ti,syscon-rgmii-delay = <&scm_conf 0x4110>;
 				/* Filled in by bootloader */
 				local-mac-address = [00 00 00 00 00 00];
 			};
@@ -148,7 +145,6 @@ icssg1_emac1: port@1 {
 				reg = <1>;
 				phy-handle = <&icssg1_phy1>;
 				phy-mode = "rgmii-id";
-				ti,syscon-rgmii-delay = <&scm_conf 0x4114>;
 				/* Filled in by bootloader */
 				local-mac-address = [00 00 00 00 00 00];
 			};
-- 
2.34.1

Re: [PATCH] arm64: dts: ti: k3-am654: Drop ti,syscon-rgmii-delay from ICSSG nodes

Posted by Roger Quadros 1 year, 11 months ago


On 15/02/2024 12:54, MD Danish Anwar wrote:
> Drop ti,syscon-rgmii-delay from ICSSG0, ICSSG1 and ICSSG2 node as this
> property is no longer used by ICSSG driver.
> 
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 2 --
>  arch/arm64/boot/dts/ti/k3-am654-idk.dtso    | 4 ----
>  2 files changed, 6 deletions(-)

What about the DT binding document?

-- 
cheers,
-roger

Re: [PATCH] arm64: dts: ti: k3-am654: Drop ti,syscon-rgmii-delay from ICSSG nodes

Posted by Anwar, Md Danish 1 year, 11 months ago


On 2/15/2024 9:27 PM, Roger Quadros wrote:
> 
> 
> On 15/02/2024 12:54, MD Danish Anwar wrote:
>> Drop ti,syscon-rgmii-delay from ICSSG0, ICSSG1 and ICSSG2 node as this
>> property is no longer used by ICSSG driver.
>>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> ---
>>  arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 2 --
>>  arch/arm64/boot/dts/ti/k3-am654-idk.dtso    | 4 ----
>>  2 files changed, 6 deletions(-)
> 
> What about the DT binding document?
> 

Now I am only removing the property from device tree. Once this proprty
is removed from all DTs, in the 6.9-rc-1 I will remove the binding as
well so that net people can merge that without getting any errors /
warnings.

-- 
Thanks and Regards,
Md Danish Anwar

Re: [PATCH] arm64: dts: ti: k3-am654: Drop ti,syscon-rgmii-delay from ICSSG nodes

Posted by Andrew Lunn 1 year, 11 months ago

On Thu, Feb 15, 2024 at 10:26:59PM +0530, Anwar, Md Danish wrote:
> 
> 
> On 2/15/2024 9:27 PM, Roger Quadros wrote:
> > 
> > 
> > On 15/02/2024 12:54, MD Danish Anwar wrote:
> >> Drop ti,syscon-rgmii-delay from ICSSG0, ICSSG1 and ICSSG2 node as this
> >> property is no longer used by ICSSG driver.
> >>
> >> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> >> ---
> >>  arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 2 --
> >>  arch/arm64/boot/dts/ti/k3-am654-idk.dtso    | 4 ----
> >>  2 files changed, 6 deletions(-)
> > 
> > What about the DT binding document?
> > 
> 
> Now I am only removing the property from device tree. Once this proprty
> is removed from all DTs, in the 6.9-rc-1 I will remove the binding as
> well so that net people can merge that without getting any errors /
> warnings.

Did the binding have the property as mandatory? If so you are probably
doing this the wrong way around. You should first modify the binding
to mark it as optional and deprecated. Then modify the .dts{i} files
to remove it.

   Andrew

Re: [PATCH] arm64: dts: ti: k3-am654: Drop ti,syscon-rgmii-delay from ICSSG nodes

Posted by Anwar, Md Danish 1 year, 11 months ago


On 2/15/2024 10:53 PM, Andrew Lunn wrote:
> On Thu, Feb 15, 2024 at 10:26:59PM +0530, Anwar, Md Danish wrote:
>>
>>
>> On 2/15/2024 9:27 PM, Roger Quadros wrote:
>>>
>>>
>>> On 15/02/2024 12:54, MD Danish Anwar wrote:
>>>> Drop ti,syscon-rgmii-delay from ICSSG0, ICSSG1 and ICSSG2 node as this
>>>> property is no longer used by ICSSG driver.
>>>>
>>>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>>>> ---
>>>>  arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 2 --
>>>>  arch/arm64/boot/dts/ti/k3-am654-idk.dtso    | 4 ----
>>>>  2 files changed, 6 deletions(-)
>>>
>>> What about the DT binding document?
>>>
>>
>> Now I am only removing the property from device tree. Once this proprty
>> is removed from all DTs, in the 6.9-rc-1 I will remove the binding as
>> well so that net people can merge that without getting any errors /
>> warnings.
> 
> Did the binding have the property as mandatory? If so you are probably
> doing this the wrong way around. You should first modify the binding
> to mark it as optional and deprecated. Then modify the .dts{i} files
> to remove it.
> 

No the binding is optional that is why I am removing this property from
DTs first.

>    Andrew

-- 
Thanks and Regards,
Md Danish Anwar

Re: [PATCH] arm64: dts: ti: k3-am654: Drop ti,syscon-rgmii-delay from ICSSG nodes

Posted by Andrew Davis 1 year, 11 months ago

On 2/15/24 4:54 AM, MD Danish Anwar wrote:
> Drop ti,syscon-rgmii-delay from ICSSG0, ICSSG1 and ICSSG2 node as this
> property is no longer used by ICSSG driver.
> 

I see a couple more instances in k3-am65-iot2050-common.dtsi.

Andrew

> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> ---
>   arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 2 --
>   arch/arm64/boot/dts/ti/k3-am654-idk.dtso    | 4 ----
>   2 files changed, 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso b/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso
> index 0a6e75265ba9..bb0e29873df7 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso
> @@ -68,7 +68,6 @@ icssg2_emac0: port@0 {
>   				reg = <0>;
>   				phy-handle = <&icssg2_phy0>;
>   				phy-mode = "rgmii-id";
> -				ti,syscon-rgmii-delay = <&scm_conf 0x4120>;
>   				/* Filled in by bootloader */
>   				local-mac-address = [00 00 00 00 00 00];
>   			};
> @@ -76,7 +75,6 @@ icssg2_emac1: port@1 {
>   				reg = <1>;
>   				phy-handle = <&icssg2_phy1>;
>   				phy-mode = "rgmii-id";
> -				ti,syscon-rgmii-delay = <&scm_conf 0x4124>;
>   				/* Filled in by bootloader */
>   				local-mac-address = [00 00 00 00 00 00];
>   			};
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-idk.dtso b/arch/arm64/boot/dts/ti/k3-am654-idk.dtso
> index 8bdb87fcbde0..d4bc80032587 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-idk.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am654-idk.dtso
> @@ -72,7 +72,6 @@ icssg0_emac0: port@0 {
>   				reg = <0>;
>   				phy-handle = <&icssg0_phy0>;
>   				phy-mode = "rgmii-id";
> -				ti,syscon-rgmii-delay = <&scm_conf 0x4100>;
>   				/* Filled in by bootloader */
>   				local-mac-address = [00 00 00 00 00 00];
>   			};
> @@ -80,7 +79,6 @@ icssg0_emac1: port@1 {
>   				reg = <1>;
>   				phy-handle = <&icssg0_phy1>;
>   				phy-mode = "rgmii-id";
> -				ti,syscon-rgmii-delay = <&scm_conf 0x4104>;
>   				/* Filled in by bootloader */
>   				local-mac-address = [00 00 00 00 00 00];
>   			};
> @@ -140,7 +138,6 @@ icssg1_emac0: port@0 {
>   				reg = <0>;
>   				phy-handle = <&icssg1_phy0>;
>   				phy-mode = "rgmii-id";
> -				ti,syscon-rgmii-delay = <&scm_conf 0x4110>;
>   				/* Filled in by bootloader */
>   				local-mac-address = [00 00 00 00 00 00];
>   			};
> @@ -148,7 +145,6 @@ icssg1_emac1: port@1 {
>   				reg = <1>;
>   				phy-handle = <&icssg1_phy1>;
>   				phy-mode = "rgmii-id";
> -				ti,syscon-rgmii-delay = <&scm_conf 0x4114>;
>   				/* Filled in by bootloader */
>   				local-mac-address = [00 00 00 00 00 00];
>   			};