extcon: max8997: select IRQ_DOMAIN instead of depending on it

[PATCH v2] extcon: max8997: select IRQ_DOMAIN instead of depending on it

Posted by Randy Dunlap 1 year, 12 months ago

IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set
it directly thru "make *config", so drivers should select it instead
of depending on it if they need it.
Relying on it being set for a dependency is risky.

Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.

Therefore, change EXTCON_MAX8997's use of "depends on" for
IRQ_DOMAIN to "select".

Fixes: dca1a71e4108 ("extcon: Add support irq domain for MAX8997 muic")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Peter Rosin <peda@axentia.se>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
v2: drop Cc: Donggeun Kim <dg77.kim@samsung.com> (bounced)

 drivers/extcon/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff -- a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
--- a/drivers/extcon/Kconfig
+++ b/drivers/extcon/Kconfig
@@ -116,7 +116,8 @@ config EXTCON_MAX77843
 
 config EXTCON_MAX8997
 	tristate "Maxim MAX8997 EXTCON Support"
-	depends on MFD_MAX8997 && IRQ_DOMAIN
+	depends on MFD_MAX8997
+	select IRQ_DOMAIN
 	help
 	  If you say yes here you get support for the MUIC device of
 	  Maxim MAX8997 PMIC. The MAX8997 MUIC is a USB port accessory

RE: [PATCH v2] extcon: max8997: select IRQ_DOMAIN instead of depending on it

Posted by Chanwoo Choi 1 year, 11 months ago


> -----Original Message-----
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Tuesday, February 13, 2024 3:00 PM
> To: linux-kernel@vger.kernel.org
> Cc: Randy Dunlap <rdunlap@infradead.org>; Arnd Bergmann <arnd@arndb.de>;
> MyungJoo Ham <myungjoo.ham@samsung.com>; Chanwoo Choi
<cw00.choi@samsung.com>;
> Marc Zyngier <maz@kernel.org>; Philipp Zabel <p.zabel@pengutronix.de>;
Peter
> Rosin <peda@axentia.se>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Subject: [PATCH v2] extcon: max8997: select IRQ_DOMAIN instead of
depending
> on it
> 
> IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
> Relying on it being set for a dependency is risky.
> 
> Consistently using "select" or "depends on" can also help reduce Kconfig
> circular dependency issues.
> 
> Therefore, change EXTCON_MAX8997's use of "depends on" for IRQ_DOMAIN to
> "select".
> 
> Fixes: dca1a71e4108 ("extcon: Add support irq domain for MAX8997 muic")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Peter Rosin <peda@axentia.se>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> v2: drop Cc: Donggeun Kim <dg77.kim@samsung.com> (bounced)
> 
>  drivers/extcon/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff -- a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -116,7 +116,8 @@ config EXTCON_MAX77843
> 
>  config EXTCON_MAX8997
>  	tristate "Maxim MAX8997 EXTCON Support"
> -	depends on MFD_MAX8997 && IRQ_DOMAIN
> +	depends on MFD_MAX8997
> +	select IRQ_DOMAIN
>  	help
>  	  If you say yes here you get support for the MUIC device of
>  	  Maxim MAX8997 PMIC. The MAX8997 MUIC is a USB port accessory

Applied it. Thanks.

Best Regards,
Chanwoo Choi

Re: [PATCH v2] extcon: max8997: select IRQ_DOMAIN instead of depending on it

Posted by Arnd Bergmann 1 year, 12 months ago

On Tue, Feb 13, 2024, at 07:00, Randy Dunlap wrote:
> IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set
> it directly thru "make *config", so drivers should select it instead
> of depending on it if they need it.
> Relying on it being set for a dependency is risky.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change EXTCON_MAX8997's use of "depends on" for
> IRQ_DOMAIN to "select".
>
> Fixes: dca1a71e4108 ("extcon: Add support irq domain for MAX8997 muic")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Arnd Bergmann <arnd@arndb.de>

Acked-by: Arnd Bergmann <arnd@arndb.de>