ARM: dts: qcom: ipq4019: add QCA8075 PHY Package nodes

[PATCH] ARM: dts: qcom: ipq4019: add QCA8075 PHY Package nodes

Posted by Christian Marangi 1 year, 12 months ago

Add QCA8075 PHY Package nodes. The PHY nodes that were previously
defined never worked and actually never had a driver to correctly setup
these PHY. Now that we have a correct driver, correctly add the PHY
Package node and set the default value of 300mw for tx driver strength
following specification of ipq4019 SoC.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi | 35 +++++++++++++++---------
 1 file changed, 22 insertions(+), 13 deletions(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi
index f989bd741cd1..6c97d852d342 100644
--- a/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-ipq4019.dtsi
@@ -603,24 +603,33 @@ mdio: mdio@90000 {
 			reg = <0x90000 0x64>;
 			status = "disabled";
 
-			ethphy0: ethernet-phy@0 {
+			ethernet-phy-package@0 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				compatible = "qcom,qca8075-package";
 				reg = <0>;
-			};
 
-			ethphy1: ethernet-phy@1 {
-				reg = <1>;
-			};
+				qcom,tx-drive-strength-milliwatt = <300>;
 
-			ethphy2: ethernet-phy@2 {
-				reg = <2>;
-			};
+				ethphy0: ethernet-phy@0 {
+					reg = <0>;
+				};
 
-			ethphy3: ethernet-phy@3 {
-				reg = <3>;
-			};
+				ethphy1: ethernet-phy@1 {
+					reg = <1>;
+				};
+
+				ethphy2: ethernet-phy@2 {
+					reg = <2>;
+				};
+
+				ethphy3: ethernet-phy@3 {
+					reg = <3>;
+				};
 
-			ethphy4: ethernet-phy@4 {
-				reg = <4>;
+				ethphy4: ethernet-phy@4 {
+					reg = <4>;
+				};
 			};
 		};
 
-- 
2.43.0

Re: [PATCH] ARM: dts: qcom: ipq4019: add QCA8075 PHY Package nodes

Posted by Bjorn Andersson 1 year, 10 months ago

On Sun, 11 Feb 2024 21:26:55 +0100, Christian Marangi wrote:
> Add QCA8075 PHY Package nodes. The PHY nodes that were previously
> defined never worked and actually never had a driver to correctly setup
> these PHY. Now that we have a correct driver, correctly add the PHY
> Package node and set the default value of 300mw for tx driver strength
> following specification of ipq4019 SoC.
> 
> 
> [...]

Applied, thanks!

[1/1] ARM: dts: qcom: ipq4019: add QCA8075 PHY Package nodes
      commit: 2338f4315f16b937e924ff679b91bb8c0ab53f25

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] ARM: dts: qcom: ipq4019: add QCA8075 PHY Package nodes

Posted by Konrad Dybcio 1 year, 12 months ago

On 11.02.2024 21:26, Christian Marangi wrote:
> Add QCA8075 PHY Package nodes. The PHY nodes that were previously
> defined never worked and actually never had a driver to correctly setup
> these PHY. 

Missing Fixes tag?

Also, could you please give me a link to the series that fixed this
on the kernel side?

Konrad

Re: [PATCH] ARM: dts: qcom: ipq4019: add QCA8075 PHY Package nodes

Posted by Robert Marko 1 year, 11 months ago

On 12. 02. 2024. 12:05, Konrad Dybcio wrote:
> On 11.02.2024 21:26, Christian Marangi wrote:
>> Add QCA8075 PHY Package nodes. The PHY nodes that were previously
>> defined never worked and actually never had a driver to correctly setup
>> these PHY.
> Missing Fixes tag?
>
> Also, could you please give me a link to the series that fixed this
> on the kernel side?

Hi Konrad,
Support for this PHY and PHY package concept was added in:
https://patchwork.kernel.org/project/netdevbpf/cover/20240206173115.7654-1-ansuelsmth@gmail.com/

Series has been merged couple of days ago so its in linux-next already.

Regards,
Robert

>
> Konrad