backlight: ktd2801: make timing struct static

[PATCH] backlight: ktd2801: make timing struct static

Posted by Duje Mihanović 1 year, 12 months ago

The struct containing the KTD2801 timing can be made static as it's not
referenced outside the KTD2801 driver. Do this to prevent sparse
complaints.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202402100625.M0RkJhMh-lkp@intel.com/
Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
---
 drivers/video/backlight/ktd2801-backlight.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/ktd2801-backlight.c b/drivers/video/backlight/ktd2801-backlight.c
index c020acff40f1..d295c2766025 100644
--- a/drivers/video/backlight/ktd2801-backlight.c
+++ b/drivers/video/backlight/ktd2801-backlight.c
@@ -13,7 +13,7 @@
 #define KTD2801_MAX_BRIGHTNESS		255
 
 /* These values have been extracted from Samsung's driver. */
-const struct expresswire_timing ktd2801_timing = {
+static const struct expresswire_timing ktd2801_timing = {
 	.poweroff_us = 2600,
 	.detect_delay_us = 150,
 	.detect_us = 270,

---
base-commit: 66c76c1cd984c14660453dfa2118014817924375
change-id: 20240210-ktd2801-static-e1c23d19600c

Best regards,
-- 
Duje Mihanović <duje.mihanovic@skole.hr>

Re: (subset) [PATCH] backlight: ktd2801: make timing struct static

Posted by Lee Jones 1 year, 11 months ago

On Sat, 10 Feb 2024 17:16:17 +0100, Duje Mihanović wrote:
> The struct containing the KTD2801 timing can be made static as it's not
> referenced outside the KTD2801 driver. Do this to prevent sparse
> complaints.
> 
> 

Applied, thanks!

[1/1] backlight: ktd2801: make timing struct static
      commit: ed2ac75acf99d33444a5d440fcad4261ad6f0d5c

--
Lee Jones [李琼斯]

Re: [PATCH] backlight: ktd2801: make timing struct static

Posted by Daniel Thompson 1 year, 12 months ago

On Sat, Feb 10, 2024 at 05:16:17PM +0100, Duje Mihanović wrote:
> The struct containing the KTD2801 timing can be made static as it's not
> referenced outside the KTD2801 driver. Do this to prevent sparse
> complaints.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202402100625.M0RkJhMh-lkp@intel.com/
> Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>


Daniel.