[PATCH 0/2] KVM: x86: kvm_has_noapic_vcpu fix/cleanup

Sean Christopherson posted 2 patches 1 year, 12 months ago
arch/x86/kvm/lapic.c | 27 ++++++++++++++++++++++++++-
arch/x86/kvm/x86.c   | 34 ++++------------------------------
2 files changed, 30 insertions(+), 31 deletions(-)
[PATCH 0/2] KVM: x86: kvm_has_noapic_vcpu fix/cleanup
Posted by Sean Christopherson 1 year, 12 months ago
Fix a longstanding bug where KVM fails to decrement kvm_has_noapic_vcpu
if vCPU creation ultimately fails.  This is obviously way more than just
a fix, but (a) in all likelihood no real users are affected by this, (b)
the absolutely worst case scenario is minor performance degredation, and
(c) I'm not at all convinced that kvm_has_noapic_vcpu provides any
performance benefits.

Sean Christopherson (2):
  KVM: x86: Move "KVM no-APIC vCPU" key management into local APIC code
  KVM: x86: Sanity check that kvm_has_noapic_vcpu is zero at
    module_exit()

 arch/x86/kvm/lapic.c | 27 ++++++++++++++++++++++++++-
 arch/x86/kvm/x86.c   | 34 ++++------------------------------
 2 files changed, 30 insertions(+), 31 deletions(-)


base-commit: 7455665a3521aa7b56245c0a2810f748adc5fdd4
-- 
2.43.0.687.g38aa6559b0-goog
Re: [PATCH 0/2] KVM: x86: kvm_has_noapic_vcpu fix/cleanup
Posted by Sean Christopherson 1 year, 11 months ago
On Fri, 09 Feb 2024 14:20:45 -0800, Sean Christopherson wrote:
> Fix a longstanding bug where KVM fails to decrement kvm_has_noapic_vcpu
> if vCPU creation ultimately fails.  This is obviously way more than just
> a fix, but (a) in all likelihood no real users are affected by this, (b)
> the absolutely worst case scenario is minor performance degredation, and
> (c) I'm not at all convinced that kvm_has_noapic_vcpu provides any
> performance benefits.
> 
> [...]

Applied to kvm-x86 misc, thanks!

[1/2] KVM: x86: Move "KVM no-APIC vCPU" key management into local APIC code
      https://github.com/kvm-x86/linux/commit/a78d9046696b
[2/2] KVM: x86: Sanity check that kvm_has_noapic_vcpu is zero at module_exit()
      https://github.com/kvm-x86/linux/commit/fc3c94142b3a

--
https://github.com/kvm-x86/linux/tree/next