mtd: rawnand: remove redundant assignment to variable bbtblocks

[PATCH][next] mtd: rawnand: remove redundant assignment to variable bbtblocks

Posted by Colin Ian King 1 year, 12 months ago

The variable bbtblocks is being assigned a value that is never
read. The assignment is redundant and can be removed.

Cleans up clang scan build warning:
drivers/mtd/nand/raw/nand_bbt.c:579:3: warning: Value stored to
'bbtblocks' is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/mtd/nand/raw/nand_bbt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/nand_bbt.c b/drivers/mtd/nand/raw/nand_bbt.c
index e4664fa6fd9e..a8fba5f39f59 100644
--- a/drivers/mtd/nand/raw/nand_bbt.c
+++ b/drivers/mtd/nand/raw/nand_bbt.c
@@ -576,7 +576,6 @@ static int search_bbt(struct nand_chip *this, uint8_t *buf,
 		startblock &= bbtblocks - 1;
 	} else {
 		chips = 1;
-		bbtblocks = mtd->size >> this->bbt_erase_shift;
 	}
 
 	for (i = 0; i < chips; i++) {
-- 
2.39.2

Re: [PATCH][next] mtd: rawnand: remove redundant assignment to variable bbtblocks

Posted by Miquel Raynal 1 year, 11 months ago

On Fri, 2024-02-09 at 17:40:19 UTC, Colin Ian King wrote:
> The variable bbtblocks is being assigned a value that is never
> read. The assignment is redundant and can be removed.
> 
> Cleans up clang scan build warning:
> drivers/mtd/nand/raw/nand_bbt.c:579:3: warning: Value stored to
> 'bbtblocks' is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel