[PATCH v3 0/3] Fixed-type GENMASK/BIT

Lucas De Marchi posted 3 patches 1 year, 10 months ago
drivers/gpu/drm/i915/i915_reg_defs.h | 108 +++------------------------
include/linux/bitops.h               |   1 -
include/linux/bits.h                 |  51 ++++++++++---
3 files changed, 51 insertions(+), 109 deletions(-)
[PATCH v3 0/3] Fixed-type GENMASK/BIT
Posted by Lucas De Marchi 1 year, 10 months ago
ove the implementation of REG_GENMASK/REG_BIT to a more appropriate
place to be shared by i915, xe and possibly other parts of the kernel.

For now this re-defines the old macros. In future we may start using the
new macros directly, but that's a more intrusive search-and-replace.

Changes from v2:

	- Document both in commit message and code about the strict type
	  checking and give examples how it´d break with invalid params.

v1: https://lore.kernel.org/intel-xe/20230509051403.2748545-1-lucas.demarchi@intel.com/
v2: https://lore.kernel.org/intel-xe/20240124050205.3646390-1-lucas.demarchi@intel.com

Lucas De Marchi (2):
  bits: Introduce fixed-type BIT
  drm/i915: Convert REG_GENMASK* to fixed-width GENMASK_*

Yury Norov (1):
  bits: introduce fixed-type genmasks

 drivers/gpu/drm/i915/i915_reg_defs.h | 108 +++------------------------
 include/linux/bitops.h               |   1 -
 include/linux/bits.h                 |  51 ++++++++++---
 3 files changed, 51 insertions(+), 109 deletions(-)

-- 
2.43.0

Re: [PATCH v3 0/3] Fixed-type GENMASK/BIT
Posted by Vincent Mailhol 10 months, 2 weeks ago
Hi Lucas and Yury,

On 08/02/2024 at 16:45, Lucas De Marchi wrote:
> ove the implementation of REG_GENMASK/REG_BIT to a more appropriate
> place to be shared by i915, xe and possibly other parts of the kernel.
> 
> For now this re-defines the old macros. In future we may start using the
> new macros directly, but that's a more intrusive search-and-replace.
> 
> Changes from v2:
> 
> 	- Document both in commit message and code about the strict type
> 	  checking and give examples how it´d break with invalid params.
> 
> v1: https://lore.kernel.org/intel-xe/20230509051403.2748545-1-lucas.demarchi@intel.com/
> v2: https://lore.kernel.org/intel-xe/20240124050205.3646390-1-lucas.demarchi@intel.com

What is the status on this series? I read it and I think this is great.
So I am a bit sad to see it stalled for nearly one year.

With the -next development windows opening very soon, wouldn't it be a
good idea to revive this topic?


Yours sincerely,
Vincent Mailhol

Re: [PATCH v3 0/3] Fixed-type GENMASK/BIT
Posted by Lucas De Marchi 10 months, 2 weeks ago
On Sun, Feb 02, 2025 at 07:40:35PM +0900, Vincent Mailhol wrote:
>Hi Lucas and Yury,
>
>On 08/02/2024 at 16:45, Lucas De Marchi wrote:
>> ove the implementation of REG_GENMASK/REG_BIT to a more appropriate
>> place to be shared by i915, xe and possibly other parts of the kernel.
>>
>> For now this re-defines the old macros. In future we may start using the
>> new macros directly, but that's a more intrusive search-and-replace.
>>
>> Changes from v2:
>>
>> 	- Document both in commit message and code about the strict type
>> 	  checking and give examples how it´d break with invalid params.
>>
>> v1: https://lore.kernel.org/intel-xe/20230509051403.2748545-1-lucas.demarchi@intel.com/
>> v2: https://lore.kernel.org/intel-xe/20240124050205.3646390-1-lucas.demarchi@intel.com
>
>What is the status on this series? I read it and I think this is great.
>So I am a bit sad to see it stalled for nearly one year.

yeah, it fell through the cracks after some regressions showed up in
linux-next. I'll take a look and re-submit later this week.

thanks
Lucas De Marchi

>
>With the -next development windows opening very soon, wouldn't it be a
>good idea to revive this topic?
>
>
>Yours sincerely,
>Vincent Mailhol
>