iio: core: make iio_bus_type const

[PATCH] iio: core: make iio_bus_type const

Posted by Ricardo B. Marliere 2 years ago

Now that the driver core can properly handle constant struct bus_type,
move the iio_bus_type variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 drivers/iio/industrialio-core.c | 2 +-
 include/linux/iio/iio.h         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index e8551a1636ba..9b2877fe8689 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -42,7 +42,7 @@ static DEFINE_IDA(iio_ida);
 static dev_t iio_devt;
 
 #define IIO_DEV_MAX 256
-struct bus_type iio_bus_type = {
+const struct bus_type iio_bus_type = {
 	.name = "iio",
 };
 EXPORT_SYMBOL(iio_bus_type);
diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
index 4f89279e531c..e370a7bb3300 100644
--- a/include/linux/iio/iio.h
+++ b/include/linux/iio/iio.h
@@ -669,7 +669,7 @@ DEFINE_GUARD_COND(iio_claim_direct, _try, ({
 int iio_device_claim_buffer_mode(struct iio_dev *indio_dev);
 void iio_device_release_buffer_mode(struct iio_dev *indio_dev);
 
-extern struct bus_type iio_bus_type;
+extern const struct bus_type iio_bus_type;
 
 /**
  * iio_device_put() - reference counted deallocation of struct device

---
base-commit: 81e8e40ea16329914f78ca1f454d04f570540ca8
change-id: 20240208-bus_cleanup-iio-1e5714e23bb9

Best regards,
-- 
Ricardo B. Marliere <ricardo@marliere.net>

Re: [PATCH] iio: core: make iio_bus_type const

Posted by Nuno Sá 2 years ago

On Thu, 2024-02-08 at 16:37 -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the iio_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---

Acked-by: Nuno Sa <nuno.sa@analog.com>

>  drivers/iio/industrialio-core.c | 2 +-
>  include/linux/iio/iio.h         | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index e8551a1636ba..9b2877fe8689 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -42,7 +42,7 @@ static DEFINE_IDA(iio_ida);
>  static dev_t iio_devt;
>  
>  #define IIO_DEV_MAX 256
> -struct bus_type iio_bus_type = {
> +const struct bus_type iio_bus_type = {
>  	.name = "iio",
>  };
>  EXPORT_SYMBOL(iio_bus_type);
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index 4f89279e531c..e370a7bb3300 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -669,7 +669,7 @@ DEFINE_GUARD_COND(iio_claim_direct, _try, ({
>  int iio_device_claim_buffer_mode(struct iio_dev *indio_dev);
>  void iio_device_release_buffer_mode(struct iio_dev *indio_dev);
>  
> -extern struct bus_type iio_bus_type;
> +extern const struct bus_type iio_bus_type;
>  
>  /**
>   * iio_device_put() - reference counted deallocation of struct device
> 
> ---
> base-commit: 81e8e40ea16329914f78ca1f454d04f570540ca8
> change-id: 20240208-bus_cleanup-iio-1e5714e23bb9
> 
> Best regards,

Re: [PATCH] iio: core: make iio_bus_type const

Posted by Jonathan Cameron 2 years ago

On Fri, 09 Feb 2024 08:38:03 +0100
Nuno Sá <noname.nuno@gmail.com> wrote:

> On Thu, 2024-02-08 at 16:37 -0300, Ricardo B. Marliere wrote:
> > Now that the driver core can properly handle constant struct bus_type,
> > move the iio_bus_type variable to be a constant structure as well,
> > placing it into read-only memory which can not be modified at runtime.
> > 
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> > ---  
> 
> Acked-by: Nuno Sa <nuno.sa@analog.com>
Applied. Thanks,

Jonathan

> 
> >  drivers/iio/industrialio-core.c | 2 +-
> >  include/linux/iio/iio.h         | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> > index e8551a1636ba..9b2877fe8689 100644
> > --- a/drivers/iio/industrialio-core.c
> > +++ b/drivers/iio/industrialio-core.c
> > @@ -42,7 +42,7 @@ static DEFINE_IDA(iio_ida);
> >  static dev_t iio_devt;
> >  
> >  #define IIO_DEV_MAX 256
> > -struct bus_type iio_bus_type = {
> > +const struct bus_type iio_bus_type = {
> >  	.name = "iio",
> >  };
> >  EXPORT_SYMBOL(iio_bus_type);
> > diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> > index 4f89279e531c..e370a7bb3300 100644
> > --- a/include/linux/iio/iio.h
> > +++ b/include/linux/iio/iio.h
> > @@ -669,7 +669,7 @@ DEFINE_GUARD_COND(iio_claim_direct, _try, ({
> >  int iio_device_claim_buffer_mode(struct iio_dev *indio_dev);
> >  void iio_device_release_buffer_mode(struct iio_dev *indio_dev);
> >  
> > -extern struct bus_type iio_bus_type;
> > +extern const struct bus_type iio_bus_type;
> >  
> >  /**
> >   * iio_device_put() - reference counted deallocation of struct device
> > 
> > ---
> > base-commit: 81e8e40ea16329914f78ca1f454d04f570540ca8
> > change-id: 20240208-bus_cleanup-iio-1e5714e23bb9
> > 
> > Best regards,  
>