[PATCH] KVM: arm64: do not source virt/lib/Kconfig twice

Masahiro Yamada posted 1 patch 2 years ago
arch/arm64/kvm/Kconfig | 1 -
1 file changed, 1 deletion(-)
[PATCH] KVM: arm64: do not source virt/lib/Kconfig twice
Posted by Masahiro Yamada 2 years ago
For ARCH=arm64, virt/lib/Kconfig is sourced twice,
from arch/arm64/kvm/Kconfig and from drivers/vfio/Kconfig.
There is no good reason to parse virt/lib/Kconfig twice.

Commit 2412405b3141 ("KVM: arm/arm64: register irq bypass consumer
on ARM/ARM64") should not have added this 'source' directive.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 arch/arm64/kvm/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig
index 6c3c8ca73e7f..27ca89b628a0 100644
--- a/arch/arm64/kvm/Kconfig
+++ b/arch/arm64/kvm/Kconfig
@@ -3,7 +3,6 @@
 # KVM configuration
 #
 
-source "virt/lib/Kconfig"
 source "virt/kvm/Kconfig"
 
 menuconfig VIRTUALIZATION
-- 
2.40.1
Re: [PATCH] KVM: arm64: do not source virt/lib/Kconfig twice
Posted by Marc Zyngier 2 years ago
On Sun, 4 Feb 2024 16:43:05 +0900, Masahiro Yamada wrote:
> For ARCH=arm64, virt/lib/Kconfig is sourced twice,
> from arch/arm64/kvm/Kconfig and from drivers/vfio/Kconfig.
> There is no good reason to parse virt/lib/Kconfig twice.
> 
> Commit 2412405b3141 ("KVM: arm/arm64: register irq bypass consumer
> on ARM/ARM64") should not have added this 'source' directive.

Applied to fixes, thanks!

[1/1] KVM: arm64: do not source virt/lib/Kconfig twice
      commit: 42dfa94d802a48c871e2017cbf86153270c86632

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.