Add the CONFIG_SND_PCM dependency for CONFIG_SND_CORE_TEST config entry
as the test uses symbols from 'pcm_misc.c'.

Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>
---
 sound/core/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/core/Kconfig b/sound/core/Kconfig
index 664c6ee2b5a1..9a44f259ccca 100644
--- a/sound/core/Kconfig
+++ b/sound/core/Kconfig
@@ -42,6 +42,7 @@ config SND_UMP_LEGACY_RAWMIDI
 config SND_CORE_TEST
 	tristate "Sound core KUnit test"
 	depends on KUNIT
+	depends on SND_PCM
 	default KUNIT_ALL_TESTS
 	help
 	  This options enables the sound core functions KUnit test.
-- 
2.34.1

On Thu, 01 Feb 2024 10:46:04 +0100,
Ivan Orlov wrote:
> 
> Add the CONFIG_SND_PCM dependency for CONFIG_SND_CORE_TEST config entry
> as the test uses symbols from 'pcm_misc.c'.
> 
> Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>

It should rather select instead of depends-on.  User can't enable
CONFIG_SND_PCM explicitly, but it's selected by the top-level
drivers.

Also, please add Fixes tag.  It's a clear regression fix.


thanks,

Takashi

On 2/1/24 13:05, Takashi Iwai wrote:
> 
> It should rather select instead of depends-on.  User can't enable
> CONFIG_SND_PCM explicitly, but it's selected by the top-level
> drivers.
> 
> Also, please add Fixes tag.  It's a clear regression fix.
> 

Alright, I'll send the V2 with suggested changes.

Thank you for the review!
-- 
Kind regards,
Ivan Orlov