net: dqs: NIC stall detector

[PATCH net v2 0/2] net: dqs: NIC stall detector

Posted by Breno Leitao 1 year, 10 months ago

This is a patch that was sent by Jakub Kicinski six month ago, and I
am reviving it.

This is still mostly Jakub's code, with some small improvements,
described in the changelog.

Changelog:
----------

v1:
  * https://lore.kernel.org/netdev/202306172057.jx7YhLiu-lkp@intel.com/T/

v2:
  * Fix the documentation file in patch 0001, since patch 0002 will
    touch it later.
  * Fix the kernel test robot issues, marking functions as statics.
  * Use #include <linux/bitops.h> instead of <asm/bitops.h>.
  * Added some new comments around, mainly around barriers.
  * Format struct `netdev_queue_attribute` assignments to make
    checkpatch happy.
  * Updated and fixed the path in sysfs-class-net-queues
    documentation.

Breno Leitao (1):
  net: sysfs: Fix /sys/class/net/<iface> path

Jakub Kicinski (1):
  net: dqs: add NIC stall detector based on BQL

 .../ABI/testing/sysfs-class-net-queues        | 45 ++++++++++----
 include/linux/dynamic_queue_limits.h          | 35 +++++++++++
 include/trace/events/napi.h                   | 33 ++++++++++
 lib/dynamic_queue_limits.c                    | 58 +++++++++++++++++
 net/core/net-sysfs.c                          | 62 +++++++++++++++++++
 5 files changed, 222 insertions(+), 11 deletions(-)

-- 
2.34.1

Re: [PATCH net v2 0/2] net: dqs: NIC stall detector

Posted by Jakub Kicinski 1 year, 10 months ago

On Wed, 31 Jan 2024 02:21:48 -0800 Breno Leitao wrote:
> Breno Leitao (1):
>   net: sysfs: Fix /sys/class/net/<iface> path

Let me take this on in, but the other one is not a fix,
so it has to go to net-next.

Re: [PATCH net v2 0/2] net: dqs: NIC stall detector

Posted by Breno Leitao 1 year, 10 months ago

On Thu, Feb 01, 2024 at 08:14:32AM -0800, Jakub Kicinski wrote:
> On Wed, 31 Jan 2024 02:21:48 -0800 Breno Leitao wrote:
> > Breno Leitao (1):
> >   net: sysfs: Fix /sys/class/net/<iface> path
> 
> Let me take this on in, but the other one is not a fix,
> so it has to go to net-next.

Sure. I didn't know how to split the dependencies. Maybe I should have
sent both of them to net-next, and you would cherry-pick the fix to net?
Is this a better approach for next time?

Re: [PATCH net v2 0/2] net: dqs: NIC stall detector

Posted by Jakub Kicinski 1 year, 10 months ago

On Thu, 1 Feb 2024 10:47:40 -0800 Breno Leitao wrote:
> > Let me take this on in, but the other one is not a fix,
> > so it has to go to net-next.  
> 
> Sure. I didn't know how to split the dependencies. Maybe I should have
> sent both of them to net-next, and you would cherry-pick the fix to net?
> Is this a better approach for next time?

You gotta send the net part and then wait until Thu afternoon Pacific
time when Linus pulls from us. We then pull net (and Linus's tree into
net-next).

Re: [PATCH net v2 0/2] net: dqs: NIC stall detector

Posted by Breno Leitao 1 year, 10 months ago

On Thu, Feb 01, 2024 at 11:43:18AM -0800, Jakub Kicinski wrote:
> On Thu, 1 Feb 2024 10:47:40 -0800 Breno Leitao wrote:
> > > Let me take this on in, but the other one is not a fix,
> > > so it has to go to net-next.  
> > 
> > Sure. I didn't know how to split the dependencies. Maybe I should have
> > sent both of them to net-next, and you would cherry-pick the fix to net?
> > Is this a better approach for next time?
> 
> You gotta send the net part and then wait until Thu afternoon Pacific
> time when Linus pulls from us. We then pull net (and Linus's tree into
> net-next).

Thanks for the clarification. I will wait for that before sending the
second patch against net-next.