dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement

[PATCH] dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement

Posted by Stefan Eichenberger 1 year, 10 months ago

From: Stefan Eichenberger <stefan.eichenberger@toradex.com>

The peer-hub is used to model the relationship between the USB 2 and USB
3 hub. However, it is possible to only connect USB 2 without having
USB 3. Therefore, the peer-hub property should not be marked as required.

Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
---
 Documentation/devicetree/bindings/usb/microchip,usb5744.yaml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
index 6d4cfd943f58..14dbb70b08fa 100644
--- a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
+++ b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
@@ -71,8 +71,6 @@ allOf:
         i2c-bus: false
     else:
       $ref: /schemas/usb/usb-device.yaml
-      required:
-        - peer-hub
 
 additionalProperties: false
 
-- 
2.40.1

Re: [PATCH] dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement

Posted by Stefan Eichenberger 1 year, 10 months ago

Hi Greg,

On Tue, Jan 30, 2024 at 08:35:05AM +0100, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> 
> The peer-hub is used to model the relationship between the USB 2 and USB
> 3 hub. However, it is possible to only connect USB 2 without having
> USB 3. Therefore, the peer-hub property should not be marked as required.

I just wanted to ask if everything is okay with the patch and if its
fine to apply it or if it needs some updates?

Regards,
Stefan

Re: [PATCH] dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement

Posted by Greg KH 1 year, 10 months ago

On Fri, Feb 09, 2024 at 09:17:02AM +0100, Stefan Eichenberger wrote:
> Hi Greg,
> 
> On Tue, Jan 30, 2024 at 08:35:05AM +0100, Stefan Eichenberger wrote:
> > From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> > 
> > The peer-hub is used to model the relationship between the USB 2 and USB
> > 3 hub. However, it is possible to only connect USB 2 without having
> > USB 3. Therefore, the peer-hub property should not be marked as required.
> 
> I just wanted to ask if everything is okay with the patch and if its
> fine to apply it or if it needs some updates?

That was only 10 days ago, please give us a chance to catch up on
reviews.

In the meantime, while waiting, please review other changes on the
lists, that way yours moves higher up in the queue.  Any reason why you
can't do that now?

thanks,

greg k-h

Re: [PATCH] dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement

Posted by Conor Dooley 1 year, 10 months ago

On Tue, Jan 30, 2024 at 08:35:05AM +0100, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> 
> The peer-hub is used to model the relationship between the USB 2 and USB
> 3 hub. However, it is possible to only connect USB 2 without having
> USB 3. Therefore, the peer-hub property should not be marked as required.
> 
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

Re: [PATCH] dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement

Posted by Michal Simek 1 year, 10 months ago


On 1/30/24 08:35, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> 
> The peer-hub is used to model the relationship between the USB 2 and USB
> 3 hub. However, it is possible to only connect USB 2 without having
> USB 3. Therefore, the peer-hub property should not be marked as required.
> 
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> ---
>   Documentation/devicetree/bindings/usb/microchip,usb5744.yaml | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
> index 6d4cfd943f58..14dbb70b08fa 100644
> --- a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
> +++ b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
> @@ -71,8 +71,6 @@ allOf:
>           i2c-bus: false
>       else:
>         $ref: /schemas/usb/usb-device.yaml
> -      required:
> -        - peer-hub
>   
>   additionalProperties: false
>   

Looks good.

Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal

Re: [PATCH] dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement

Posted by Francesco Dolcini 1 year, 10 months ago

On Tue, Jan 30, 2024 at 08:35:05AM +0100, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> 
> The peer-hub is used to model the relationship between the USB 2 and USB
> 3 hub. However, it is possible to only connect USB 2 without having
> USB 3. Therefore, the peer-hub property should not be marked as required.

This was noticed while adding this HUB in the DTS on a board in which
USB3 is not supported. To some extent this is fix.

> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Francesco