[PATCH 00/18] ALSA: Various fixes for Cirrus Logic CS35L56 support

Richard Fitzgerald posted 18 patches 1 year, 10 months ago
include/sound/cs35l56.h           |   7 +-
sound/pci/hda/cs35l56_hda.c       | 138 ++++++++------
sound/soc/codecs/cs35l56-shared.c | 140 ++++++++++++--
sound/soc/codecs/cs35l56.c        | 307 +++++++++++++++++++++++++-----
sound/soc/codecs/cs35l56.h        |   2 +
sound/soc/codecs/wm_adsp.c        |  73 +++----
6 files changed, 498 insertions(+), 169 deletions(-)
[PATCH 00/18] ALSA: Various fixes for Cirrus Logic CS35L56 support
Posted by Richard Fitzgerald 1 year, 10 months ago
This chain of patches fixes various things that were undocumented, unknown
or uncertain when the original driver code was written. And also a few
things that were just bugs.

The HDA patches have dependencies on the ASoC patches, except for the final
patch that removes a bogus test stub function.

Richard Fitzgerald (18):
  ASoC: wm_adsp: Fix firmware file search order
  ASoC: wm_adsp: Don't overwrite fwf_name with the default
  ASoC: cs35l56: cs35l56_component_remove() must clear
    cs35l56->component
  ASoC: cs35l56: cs35l56_component_remove() must clean up wm_adsp
  ASoC: cs35l56: Don't add the same register patch multiple times
  ASoC: cs35l56: Remove buggy checks from cs35l56_is_fw_reload_needed()
  ASoC: cs35l56: Fix to ensure ASP1 registers match cache
  ASoC: cs35l56: Fix default SDW TX mixer registers
  ALSA: hda: cs35l56: Initialize all ASP1 registers
  ASoC: cs35l56: Fix for initializing ASP1 mixer registers
  ASoC: cs35l56: Fix misuse of wm_adsp 'part' string for silicon
    revision
  ASoC: cs35l56: Firmware file must match the version of preloaded
    firmware
  ASoC: cs35l56: Load tunings for the correct speaker models
  ASoC: cs35l56: Allow more time for firmware to boot
  ALSA: hda: cs35l56: Fix order of searching for firmware files
  ALSA: hda: cs35l56: Fix filename string field layout
  ALSA: hda: cs35l56: Firmware file must match the version of preloaded
    firmware
  ALSA: hda: cs35l56: Remove unused test stub function

 include/sound/cs35l56.h           |   7 +-
 sound/pci/hda/cs35l56_hda.c       | 138 ++++++++------
 sound/soc/codecs/cs35l56-shared.c | 140 ++++++++++++--
 sound/soc/codecs/cs35l56.c        | 307 +++++++++++++++++++++++++-----
 sound/soc/codecs/cs35l56.h        |   2 +
 sound/soc/codecs/wm_adsp.c        |  73 +++----
 6 files changed, 498 insertions(+), 169 deletions(-)

-- 
2.39.2
Re: [PATCH 00/18] ALSA: Various fixes for Cirrus Logic CS35L56 support
Posted by Mark Brown 1 year, 10 months ago
On Mon, Jan 29, 2024 at 04:27:19PM +0000, Richard Fitzgerald wrote:
> This chain of patches fixes various things that were undocumented, unknown
> or uncertain when the original driver code was written. And also a few
> things that were just bugs.
> 
> The HDA patches have dependencies on the ASoC patches, except for the final
> patch that removes a bogus test stub function.

Takashi, should I apply the ALSA bits of this via ASoC?
Re: [PATCH 00/18] ALSA: Various fixes for Cirrus Logic CS35L56 support
Posted by Takashi Iwai 1 year, 10 months ago
On Thu, 01 Feb 2024 13:47:38 +0100,
Mark Brown wrote:
> 
> On Mon, Jan 29, 2024 at 04:27:19PM +0000, Richard Fitzgerald wrote:
> > This chain of patches fixes various things that were undocumented, unknown
> > or uncertain when the original driver code was written. And also a few
> > things that were just bugs.
> > 
> > The HDA patches have dependencies on the ASoC patches, except for the final
> > patch that removes a bogus test stub function.
> 
> Takashi, should I apply the ALSA bits of this via ASoC?

Judging from the amount, better to go through your tree.
Please go ahead.


thanks,

Takashi
Re: [PATCH 00/18] ALSA: Various fixes for Cirrus Logic CS35L56 support
Posted by Mark Brown 1 year, 10 months ago
On Mon, 29 Jan 2024 16:27:19 +0000, Richard Fitzgerald wrote:
> This chain of patches fixes various things that were undocumented, unknown
> or uncertain when the original driver code was written. And also a few
> things that were just bugs.
> 
> The HDA patches have dependencies on the ASoC patches, except for the final
> patch that removes a bogus test stub function.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[01/18] ASoC: wm_adsp: Fix firmware file search order
        commit: 3657e4cb5a8abd9edf6c944e022fe9ef06989960
[02/18] ASoC: wm_adsp: Don't overwrite fwf_name with the default
        commit: daf3f0f99cde93a066240462b7a87cdfeedc04c0
[03/18] ASoC: cs35l56: cs35l56_component_remove() must clear cs35l56->component
        commit: ae861c466ee57e15a29d97629e1c564e3f714a4f
[04/18] ASoC: cs35l56: cs35l56_component_remove() must clean up wm_adsp
        commit: cd38ccbecdace1469b4e0cfb3ddeec72a3fad226
[05/18] ASoC: cs35l56: Don't add the same register patch multiple times
        commit: 07687cd0539f8185b6ba0c0afba8473517116d6a
[06/18] ASoC: cs35l56: Remove buggy checks from cs35l56_is_fw_reload_needed()
        commit: 3739cc0733ba7eeafc08d4d4208d1f3c2451eabd
[07/18] ASoC: cs35l56: Fix to ensure ASP1 registers match cache
        commit: 72a77d7631c6e392677c0134343cf5edcd3a4572
[08/18] ASoC: cs35l56: Fix default SDW TX mixer registers
        commit: 782e6c538be43a17e34f552ab49e8c713cac7883
[09/18] ALSA: hda: cs35l56: Initialize all ASP1 registers
        commit: 856ce8982169acb31a25c5f2ecd2570ab8a6af46
[10/18] ASoC: cs35l56: Fix for initializing ASP1 mixer registers
        commit: 07f7d6e7a124d3e4de36771e2a4926d0e31c2258
[11/18] ASoC: cs35l56: Fix misuse of wm_adsp 'part' string for silicon revision
        commit: f6c967941c5d6fa526fdd64733a8d86bf2bfab31
[12/18] ASoC: cs35l56: Firmware file must match the version of preloaded firmware
        commit: f4ef5149953f2fc04907ca5b34db3df667dcddef
[13/18] ASoC: cs35l56: Load tunings for the correct speaker models
        commit: 245eeff18d7a37693815250ae15979ce98c3d190
[14/18] ASoC: cs35l56: Allow more time for firmware to boot
        commit: 9e92b77ceb6f362eb2e7995dad6c7f9863053d97
[15/18] ALSA: hda: cs35l56: Fix order of searching for firmware files
        commit: 77c60722ded7d6739805e045e9648cda82dde5ed
[16/18] ALSA: hda: cs35l56: Fix filename string field layout
        commit: e82bc517c6ef5d5c04b845420406e694c31bdb8a
[17/18] ALSA: hda: cs35l56: Firmware file must match the version of preloaded firmware
        commit: 6f8ad0480d82245961dae4d3280908611633872d
[18/18] ALSA: hda: cs35l56: Remove unused test stub function
        commit: 28876c1ae8b8cd1dacef50bd6c0555824774f0d2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark