perf evsel: Fix duplicate initialization of data->id in evsel__parse_sample()

[PATCH] perf evsel: Fix duplicate initialization of data->id in evsel__parse_sample()

Posted by Yang Jihong 1 year, 11 months ago

data->id has been initialized at line 2362, remove duplicate initialization.

Fixes: 3ad31d8a0df2 ("perf evsel: Centralize perf_sample initialization")
Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
---
 tools/perf/util/evsel.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 4d14f14f2506..a0f36a6b8a2d 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -2363,7 +2363,6 @@ int evsel__parse_sample(struct evsel *evsel, union perf_event *event,
 	data->period = evsel->core.attr.sample_period;
 	data->cpumode = event->header.misc & PERF_RECORD_MISC_CPUMODE_MASK;
 	data->misc    = event->header.misc;
-	data->id = -1ULL;
 	data->data_src = PERF_MEM_DATA_SRC_NONE;
 	data->vcpu = -1;
 
-- 
2.34.1

Re: [PATCH] perf evsel: Fix duplicate initialization of data->id in evsel__parse_sample()

Posted by Namhyung Kim 1 year, 10 months ago

On Sat, 27 Jan 2024 02:57:56 +0000, Yang Jihong wrote:
> data->id has been initialized at line 2362, remove duplicate initialization.
> 
> 

Applied to perf-tools-next, thanks!

Best regards,
-- 
Namhyung Kim <namhyung@kernel.org>

Re: [PATCH] perf evsel: Fix duplicate initialization of data->id in evsel__parse_sample()

Posted by Arnaldo Carvalho de Melo 1 year, 11 months ago

Em Sat, Jan 27, 2024 at 02:57:56AM +0000, Yang Jihong escreveu:
> data->id has been initialized at line 2362, remove duplicate initialization.
> 
> Fixes: 3ad31d8a0df2 ("perf evsel: Centralize perf_sample initialization")
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>

Reviewed-by: Arnaldo Carvalho de Melo <acme@redhat.com>

- Arnaldo

> ---
>  tools/perf/util/evsel.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 4d14f14f2506..a0f36a6b8a2d 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -2363,7 +2363,6 @@ int evsel__parse_sample(struct evsel *evsel, union perf_event *event,
>  	data->period = evsel->core.attr.sample_period;
>  	data->cpumode = event->header.misc & PERF_RECORD_MISC_CPUMODE_MASK;
>  	data->misc    = event->header.misc;
> -	data->id = -1ULL;
>  	data->data_src = PERF_MEM_DATA_SRC_NONE;
>  	data->vcpu = -1;
>  
> -- 
> 2.34.1
> 

-- 

- Arnaldo

Re: [PATCH] perf evsel: Fix duplicate initialization of data->id in evsel__parse_sample()

Posted by Ian Rogers 1 year, 11 months ago

On Fri, Jan 26, 2024 at 7:02 PM Yang Jihong <yangjihong1@huawei.com> wrote:
>
> data->id has been initialized at line 2362, remove duplicate initialization.
>
> Fixes: 3ad31d8a0df2 ("perf evsel: Centralize perf_sample initialization")
> Signed-off-by: Yang Jihong <yangjihong1@huawei.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian