[v4] Introduce EC-based watchdog

[PATCH v4 0/3] Introduce EC-based watchdog

Posted by Lukasz Majczak 1 year, 11 months ago

Chromeos devices are equipped with the embedded controller (EC)
that can be used as a watchdog. The following patches
updates the structures and definitions required to
communicate with EC-based watchdog and implements the
driver itself.

V1:https://patchwork.kernel.org/project/linux-watchdog/patch/20240117102450.4080839-1-lma@chromium.org/
V2:https://patchwork.kernel.org/project/linux-watchdog/list/?series=817925
V3:https://patchwork.kernel.org/project/linux-watchdog/list/?series=818036

Changelog
V3->V4:
* updated sizeof() argument with pointer dereference
* added cros_ec_wdt_id to the driver structure
* "mfd: cros_ec: Register EC-based watchdog subdevice"
  has been already applied to the for-mfd-next
V2->V3:
* drop "-drv" from driver name
* use format #define<space>NAME<tab>value
V1->V2:
* Split into three patches
* Supplement the watchdog configuration with min/max timeouts
* Removed struct cros_ec_wdt_data  and get aligned to watchdog framework
* Simplified suspend/resume callbacks
* Removed excessive log messages
* Reworked cros_ec_wdt_send_hang_detect() function to be more generic
* Usage of devm_* allowed to delete .remove module callback
* Changed MODULE_ALIAS to MODULE_DEVICE_TABLE
* Moved clearing bootstatus (on EC) to probe() and thanks to that
  got rid of .shutdown() module callback
* Fixed/removed comments, removed unused includes and general cleanup

Best regards,
Lukasz

Lukasz Majczak (3):
  platform/chrome: Update binary interface for EC-based watchdog
  watchdog: Add ChromeOS EC-based watchdog driver
  mfd: cros_ec: Register EC-based watchdog subdevice

 MAINTAINERS                                   |   6 +
 drivers/mfd/cros_ec_dev.c                     |   9 +
 drivers/watchdog/Kconfig                      |  11 +
 drivers/watchdog/Makefile                     |   1 +
 drivers/watchdog/cros_ec_wdt.c                | 204 ++++++++++++++++++
 .../linux/platform_data/cros_ec_commands.h    |  78 +++----
 6 files changed, 266 insertions(+), 43 deletions(-)
 create mode 100644 drivers/watchdog/cros_ec_wdt.c

-- 
2.43.0.429.g432eaa2c6b-goog

[GIT PULL] Immutable branch between MFD, CROS and Watchdog due for the v6.9 merge window

Posted by Lee Jones 1 year, 10 months ago

Good afternoon,

The following changes since commit 6613476e225e090cc9aad49be7fa504e290dd33d:

  Linux 6.8-rc1 (2024-01-21 14:11:32 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-cros-watchdog-v6.9

for you to fetch changes up to 843dac4d3687f7628ba4f76e1481ee3838b27a35:

  watchdog: Add ChromeOS EC-based watchdog driver (2024-02-01 11:49:30 +0000)

----------------------------------------------------------------
Immutable branch between MFD, CROS and Watchdog due for the v6.9 merge window

----------------------------------------------------------------
Lukasz Majczak (2):
      platform/chrome: Update binary interface for EC-based watchdog
      watchdog: Add ChromeOS EC-based watchdog driver

 MAINTAINERS                                    |   6 +
 drivers/watchdog/Kconfig                       |  11 ++
 drivers/watchdog/Makefile                      |   1 +
 drivers/watchdog/cros_ec_wdt.c                 | 204 +++++++++++++++++++++++++
 include/linux/platform_data/cros_ec_commands.h |  78 +++++-----
 5 files changed, 257 insertions(+), 43 deletions(-)
 create mode 100644 drivers/watchdog/cros_ec_wdt.c

-- 
Lee Jones [李琼斯]

Re: [GIT PULL] Immutable branch between MFD, CROS and Watchdog due for the v6.9 merge window

Posted by Łukasz Majczak 1 year, 10 months ago

On Thu, Feb 1, 2024 at 2:06 PM Lee Jones <lee@kernel.org> wrote:
>
> Good afternoon,
>
> The following changes since commit 6613476e225e090cc9aad49be7fa504e290dd33d:
>
>   Linux 6.8-rc1 (2024-01-21 14:11:32 -0800)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-cros-watchdog-v6.9
>
> for you to fetch changes up to 843dac4d3687f7628ba4f76e1481ee3838b27a35:
>
>   watchdog: Add ChromeOS EC-based watchdog driver (2024-02-01 11:49:30 +0000)
>
> ----------------------------------------------------------------
> Immutable branch between MFD, CROS and Watchdog due for the v6.9 merge window
>
> ----------------------------------------------------------------
> Lukasz Majczak (2):
>       platform/chrome: Update binary interface for EC-based watchdog
>       watchdog: Add ChromeOS EC-based watchdog driver
>
>  MAINTAINERS                                    |   6 +
>  drivers/watchdog/Kconfig                       |  11 ++
>  drivers/watchdog/Makefile                      |   1 +
>  drivers/watchdog/cros_ec_wdt.c                 | 204 +++++++++++++++++++++++++
>  include/linux/platform_data/cros_ec_commands.h |  78 +++++-----
>  5 files changed, 257 insertions(+), 43 deletions(-)
>  create mode 100644 drivers/watchdog/cros_ec_wdt.c
>
> --
> Lee Jones [李琼斯]

Hi Lee,

I'm about to sent V5 of patches:
* watchdog: Add ChromeOS EC-based watchdog driver
* platform/chrome: Update binary interface for EC-based watchdog
but I'm not sure how I should proceed - can I base those on the master
branch or shall I rebase on top of  ib-mfd-cros-watchdog-v6.9?

Best regards,
Lukasz

Re: [GIT PULL] Immutable branch between MFD, CROS and Watchdog due for the v6.9 merge window

Posted by Lee Jones 1 year, 10 months ago

On Fri, 02 Feb 2024, Łukasz Majczak wrote:

> On Thu, Feb 1, 2024 at 2:06 PM Lee Jones <lee@kernel.org> wrote:
> >
> > Good afternoon,
> >
> > The following changes since commit 6613476e225e090cc9aad49be7fa504e290dd33d:
> >
> >   Linux 6.8-rc1 (2024-01-21 14:11:32 -0800)
> >
> > are available in the Git repository at:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-cros-watchdog-v6.9
> >
> > for you to fetch changes up to 843dac4d3687f7628ba4f76e1481ee3838b27a35:
> >
> >   watchdog: Add ChromeOS EC-based watchdog driver (2024-02-01 11:49:30 +0000)
> >
> > ----------------------------------------------------------------
> > Immutable branch between MFD, CROS and Watchdog due for the v6.9 merge window
> >
> > ----------------------------------------------------------------
> > Lukasz Majczak (2):
> >       platform/chrome: Update binary interface for EC-based watchdog
> >       watchdog: Add ChromeOS EC-based watchdog driver
> >
> >  MAINTAINERS                                    |   6 +
> >  drivers/watchdog/Kconfig                       |  11 ++
> >  drivers/watchdog/Makefile                      |   1 +
> >  drivers/watchdog/cros_ec_wdt.c                 | 204 +++++++++++++++++++++++++
> >  include/linux/platform_data/cros_ec_commands.h |  78 +++++-----
> >  5 files changed, 257 insertions(+), 43 deletions(-)
> >  create mode 100644 drivers/watchdog/cros_ec_wdt.c
> >
> > --
> > Lee Jones [李琼斯]
> 
> Hi Lee,
> 
> I'm about to sent V5 of patches:
> * watchdog: Add ChromeOS EC-based watchdog driver
> * platform/chrome: Update binary interface for EC-based watchdog

These patches are applied, you cannot resend them.

If you need to make adjustments, please submit incremental changes.

> but I'm not sure how I should proceed - can I base those on the master
> branch or shall I rebase on top of  ib-mfd-cros-watchdog-v6.9?

Unless it causes issues, I tend to work on Linux next.

-- 
Lee Jones [李琼斯]