Dear Jiri & Team,

I hope this email finds you well.  
As per the review comments given by Mr. Jiri and Mr. Joe Perches in our last converstaion over mail.
We have incorporated the feedback on our driver. Please check this set of series and help us to improve samsung driver.

As of today, Opensource kernel Samsung driver only supports USB HID devices and do not have support for Bluetooth HID devices. 
Samsung would like to improve the samsung driver and extend it's support for bluetooth devices as well.

Summary of changes in Samsung driver:
 1. Add support for below bluetooth devices

	Samsung wireless Keyboard
	Samsung wireless GamePad
	Samsung Wireless Action Mouse
	Samsung Wireless Book Cover
	Samsung Wireless Universal Keyboard
	Samsung Wireless HOGP Keyboard
 2. Add support for Special key processing on each of the above devices.
 
 Patch Series Overview:
--------------------------------------

[Patch 1/6]

HID Samsung : Broaden device compatibility in samsung driver.

hid_is_usb() check being moved.

[Patch 2/6]

HID: Samsung : Fix the checkpatch complain.

Warning found by checkpatch.pl script.

[Patch 3/6]

HID: Samsung : Add Samsung wireless keyboard support.

[Patch 4/6]

HID: Samsung : Add Samsung wireless gamepad support.

[Patch 5/6]

HID: Samsung : Add Samsung wireless action mouse support.

[Patch 6/6]

HID: Samsung : Add Samsung wireless bookcover and universal keyboard support.



All these changes have been verified and tested thoroughly in android devices.
Please accept our changes.


Thanks for your time and consideration.

Best regards
Sandeep C S

Sandeep C S (6):
  HID Samsung : Broaden device compatibility in samsung driver.
  HID: Samsung : Fix the checkpatch complain. Rewritten code using
    memcmp where applicable.
  HID: Samsung : Add Samsung wireless keyboard support.
  HID: Samsung : Add Samsung wireless gamepad support.
  HID: Samsung : Add Samsung wireless action mouse support.
  HID: Samsung : Add Samsung wireless bookcover and universal keyboard
    support.

 drivers/hid/hid-ids.h     |   7 +
 drivers/hid/hid-samsung.c | 437 ++++++++++++++++++++++++++++++++++----
 2 files changed, 408 insertions(+), 36 deletions(-)

-- 
2.34.1

On Thu, 25 Jan 2024, Sandeep C S wrote:

> Dear Jiri & Team,
> 
> I hope this email finds you well.  As per the review comments given by 
> Mr. Jiri and Mr. Joe Perches in our last converstaion over mail. We have 
> incorporated the feedback on our driver. Please check this set of series 
> and help us to improve samsung driver.
> 
> As of today, Opensource kernel Samsung driver only supports USB HID 
> devices and do not have support for Bluetooth HID devices. Samsung would 
> like to improve the samsung driver and extend it's support for bluetooth 
> devices as well.
> 
> Summary of changes in Samsung driver:
>  1. Add support for below bluetooth devices
> 
> 	Samsung wireless Keyboard
> 	Samsung wireless GamePad
> 	Samsung Wireless Action Mouse
> 	Samsung Wireless Book Cover
> 	Samsung Wireless Universal Keyboard
> 	Samsung Wireless HOGP Keyboard
>  2. Add support for Special key processing on each of the above devices.

I have updated the changelogs so that they are up to the subsystem 
standards (please check the git tree and try to adhere to similar format 
for your next submissions), and applied, thanks for the patches!

-- 
Jiri Kosina
SUSE Labs

>On Thu, 25 Jan 2024, Sandeep C S wrote:
>
>> Dear Jiri & Team,
>>
>> I hope this email finds you well.  As per the review comments given by
>> Mr. Jiri and Mr. Joe Perches in our last converstaion over mail. We
>> have incorporated the feedback on our driver. Please check this set of
>> series and help us to improve samsung driver.
>>
>> As of today, Opensource kernel Samsung driver only supports USB HID
>> devices and do not have support for Bluetooth HID devices. Samsung
>> would like to improve the samsung driver and extend it's support for
>> bluetooth devices as well.
>>
>> Summary of changes in Samsung driver:
>>  1. Add support for below bluetooth devices
>>
>> 	Samsung wireless Keyboard
>> 	Samsung wireless GamePad
>> 	Samsung Wireless Action Mouse
>> 	Samsung Wireless Book Cover
>> 	Samsung Wireless Universal Keyboard
>> 	Samsung Wireless HOGP Keyboard
>>  2. Add support for Special key processing on each of the above devices.
>
>I have updated the changelogs so that they are up to the subsystem
standards
>(please check the git tree and try to adhere to similar format for your
next
>submissions), and applied, thanks for the patches!
>
>--
>Jiri Kosina
>SUSE Labs

Thank you for accepting our changes! We will make sure follow the same
format for future submissions as well.

Thanks & regards
Sandeep C S

>> Dear Jiri & Team,
>>
>> I hope this email finds you well.  As per the review comments given by
>> Mr. Jiri and Mr. Joe Perches in our last converstaion over mail. We
>> have incorporated the feedback on our driver. Please check this set of
>> series and help us to improve samsung driver.
>>
>> As of today, Opensource kernel Samsung driver only supports USB HID
>> devices and do not have support for Bluetooth HID devices. Samsung
>> would like to improve the samsung driver and extend it's support for
>> bluetooth devices as well.
>>
>> Summary of changes in Samsung driver:
>>  1. Add support for below bluetooth devices
>>
>> 	Samsung wireless Keyboard
>> 	Samsung wireless GamePad
>> 	Samsung Wireless Action Mouse
>> 	Samsung Wireless Book Cover
>> 	Samsung Wireless Universal Keyboard
>> 	Samsung Wireless HOGP Keyboard
>>  2. Add support for Special key processing on each of the above devices.
>
>I have updated the changelogs so that they are up to the subsystem
standards
>(please check the git tree and try to adhere to similar format for your
next
>submissions), and applied, thanks for the patches!

Thank you for accepting our changes and for your feedback.
We will make sure to adhere to the subsystem standard for future
submissions.

Thanks & regards
Sandeep C S