dt-bindings: ufs: samsung,exynos-ufs: Add size constraints on "samsung,sysreg"

[PATCH] dt-bindings: ufs: samsung,exynos-ufs: Add size constraints on "samsung,sysreg"

Posted by Rob Herring 1 year, 11 months ago

The 'phandle-array' type is a bit ambiguous. It can be either just an
array of phandles or an array of phandles plus args. "samsung,sysreg" is
the latter and needs to be constrained to a single entry with a phandle and
offset.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/ufs/samsung,exynos-ufs.yaml      | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
index 88cc1e3a0c88..b2b509b3944d 100644
--- a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
@@ -55,9 +55,12 @@ properties:
 
   samsung,sysreg:
     $ref: /schemas/types.yaml#/definitions/phandle-array
-    description: Should be phandle/offset pair. The phandle to the syscon node
-                 which indicates the FSYSx sysreg interface and the offset of
-                 the control register for UFS io coherency setting.
+    items:
+      - items:
+          - description: phandle to FSYSx sysreg node
+          - description: offset of the control register for UFS io coherency setting
+    description:
+      Phandle and offset to the FSYSx sysreg for UFS io coherency setting.
 
   dma-coherent: true
 
-- 
2.43.0

Re: [PATCH] dt-bindings: ufs: samsung,exynos-ufs: Add size constraints on "samsung,sysreg"

Posted by Rob Herring 1 year, 10 months ago

On Wed, 24 Jan 2024 13:07:33 -0600, Rob Herring wrote:
> The 'phandle-array' type is a bit ambiguous. It can be either just an
> array of phandles or an array of phandles plus args. "samsung,sysreg" is
> the latter and needs to be constrained to a single entry with a phandle and
> offset.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  .../devicetree/bindings/ufs/samsung,exynos-ufs.yaml      | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 

Applied, thanks!

Re: [PATCH] dt-bindings: ufs: samsung,exynos-ufs: Add size constraints on "samsung,sysreg"

Posted by Krzysztof Kozlowski 1 year, 11 months ago

On 24/01/2024 20:07, Rob Herring wrote:
> The 'phandle-array' type is a bit ambiguous. It can be either just an
> array of phandles or an array of phandles plus args. "samsung,sysreg" is
> the latter and needs to be constrained to a single entry with a phandle and
> offset.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof