[PATCH 06/15] tick: No need to clear ts->next_tick again

Frederic Weisbecker posted 15 patches 1 year, 11 months ago
There is a newer version of this series
[PATCH 06/15] tick: No need to clear ts->next_tick again
Posted by Frederic Weisbecker 1 year, 11 months ago
The tick sched structure is already cleared from
tick_cancel_sched_timer(), so there is no need to clear that field
again.

Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
---
 kernel/time/tick-sched.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 4089bd274d8e..e8e3b5d447e9 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -1101,11 +1101,6 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts)
 	if (unlikely(!cpu_online(cpu))) {
 		if (cpu == tick_do_timer_cpu)
 			tick_do_timer_cpu = TICK_DO_TIMER_NONE;
-		/*
-		 * Make sure the CPU doesn't get fooled by obsolete tick
-		 * deadline if it comes back online later.
-		 */
-		ts->next_tick = 0;
 		return false;
 	}
 
-- 
2.43.0
Re: [PATCH 06/15] tick: No need to clear ts->next_tick again
Posted by Thomas Gleixner 1 year, 11 months ago
On Wed, Jan 24 2024 at 18:04, Frederic Weisbecker wrote:

> The tick sched structure is already cleared from
> tick_cancel_sched_timer(), so there is no need to clear that field
> again.
>
> Signed-off-by: Frederic Weisbecker <frederic@kernel.org>

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>