gpio: cdev: remove leftover function pointer typedefs

[PATCH] gpio: cdev: remove leftover function pointer typedefs

Posted by Bartosz Golaszewski 1 year, 11 months ago

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

The locking wrappers were replaces with lock guards. These typedefs are
no longer needed.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/gpiolib-cdev.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
index 2a88736629ef..34d6712fa07c 100644
--- a/drivers/gpio/gpiolib-cdev.c
+++ b/drivers/gpio/gpiolib-cdev.c
@@ -61,11 +61,6 @@ static_assert(IS_ALIGNED(sizeof(struct gpio_v2_line_values), 8));
  * interface to gpiolib GPIOs via ioctl()s.
  */
 
-typedef __poll_t (*poll_fn)(struct file *, struct poll_table_struct *);
-typedef long (*ioctl_fn)(struct file *, unsigned int, unsigned long);
-typedef ssize_t (*read_fn)(struct file *, char __user *,
-			   size_t count, loff_t *);
-
 /*
  * GPIO line handle management
  */
-- 
2.40.1

Re: [PATCH] gpio: cdev: remove leftover function pointer typedefs

Posted by Linus Walleij 1 year, 10 months ago

On Wed, Jan 24, 2024 at 5:17 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The locking wrappers were replaces with lock guards. These typedefs are
> no longer needed.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH] gpio: cdev: remove leftover function pointer typedefs

Posted by Kent Gibson 1 year, 11 months ago

On Wed, Jan 24, 2024 at 05:17:25PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The locking wrappers were replaces with lock guards. These typedefs are
> no longer needed.
>

replaced

Given that,

Reviewed-by: Kent Gibson <warthog618@gmail.com>

> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  drivers/gpio/gpiolib-cdev.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> index 2a88736629ef..34d6712fa07c 100644
> --- a/drivers/gpio/gpiolib-cdev.c
> +++ b/drivers/gpio/gpiolib-cdev.c
> @@ -61,11 +61,6 @@ static_assert(IS_ALIGNED(sizeof(struct gpio_v2_line_values), 8));
>   * interface to gpiolib GPIOs via ioctl()s.
>   */
>
> -typedef __poll_t (*poll_fn)(struct file *, struct poll_table_struct *);
> -typedef long (*ioctl_fn)(struct file *, unsigned int, unsigned long);
> -typedef ssize_t (*read_fn)(struct file *, char __user *,
> -			   size_t count, loff_t *);
> -
>  /*
>   * GPIO line handle management
>   */
> --
> 2.40.1
>