1. Patchew
  2. linux
  3. [PATCH 0/2] dt-bindings: pinctrl: qcom: update SM4450 pinctrl
  4. View patch

[PATCH 1/2] dt-bindings: pinctrl: qcom: modify the wrong compatible name

Tengfei Fan posted 2 patches 1 year, 11 months ago
[PATCH 1/2] dt-bindings: pinctrl: qcom: modify the wrong compatible name
Posted by Tengfei Fan 1 year, 11 months ago 
Use right compatible name "qcom,sm4450-tlmm" instead of
"qcom,sm4450-pinctrl".

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
index bb08ca5a1509..bb675c8ec220 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
@@ -17,7 +17,7 @@ allOf:
 
 properties:
   compatible:
-    const: qcom,sm4450-pinctrl
+    const: qcom,sm4450-tlmm
 
   reg:
     maxItems: 1
-- 
2.17.1
Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: modify the wrong compatible name
Posted by Krzysztof Kozlowski 1 year, 11 months ago 
On 24/01/2024 03:33, Tengfei Fan wrote:
> Use right compatible name "qcom,sm4450-tlmm" instead of
> "qcom,sm4450-pinctrl".

Why do you claim this one is right and other is wrong? Provide
arguments. To me the compatible looks correct.

Best regards,
Krzysztof
Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: modify the wrong compatible name
Posted by Dmitry Baryshkov 1 year, 11 months ago 
On Wed, 24 Jan 2024 at 08:38, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 24/01/2024 03:33, Tengfei Fan wrote:
> > Use right compatible name "qcom,sm4450-tlmm" instead of
> > "qcom,sm4450-pinctrl".
>
> Why do you claim this one is right and other is wrong? Provide
> arguments. To me the compatible looks correct.

Yeah, but the driver (and the dtsi) use -tlmm


-- 
With best wishes
Dmitry
Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: modify the wrong compatible name
Posted by Krzysztof Kozlowski 1 year, 11 months ago 
On 24/01/2024 09:07, Dmitry Baryshkov wrote:
> On Wed, 24 Jan 2024 at 08:38, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 24/01/2024 03:33, Tengfei Fan wrote:
>>> Use right compatible name "qcom,sm4450-tlmm" instead of
>>> "qcom,sm4450-pinctrl".
>>
>> Why do you claim this one is right and other is wrong? Provide
>> arguments. To me the compatible looks correct.
> 
> Yeah, but the driver (and the dtsi) use -tlmm

Are they merged? If so, it would be the argument for the commit msg.
Just provide some rationale why this is done this way, not the other
(fixing driver and DTS).

Best regards,
Krzysztof
Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: modify the wrong compatible name
Posted by Tengfei Fan 1 year, 11 months ago 

On 1/24/2024 4:46 PM, Krzysztof Kozlowski wrote:
> On 24/01/2024 09:07, Dmitry Baryshkov wrote:
>> On Wed, 24 Jan 2024 at 08:38, Krzysztof Kozlowski
>> <krzysztof.kozlowski@linaro.org> wrote:
>>>
>>> On 24/01/2024 03:33, Tengfei Fan wrote:
>>>> Use right compatible name "qcom,sm4450-tlmm" instead of
>>>> "qcom,sm4450-pinctrl".
>>>
>>> Why do you claim this one is right and other is wrong? Provide
>>> arguments. To me the compatible looks correct.
>>
>> Yeah, but the driver (and the dtsi) use -tlmm
> 
> Are they merged? If so, it would be the argument for the commit msg.
> Just provide some rationale why this is done this way, not the other
> (fixing driver and DTS).
> 
> Best regards,
> Krzysztof
> 

This commit message is causing some confusion. I will update this commit 
messge for just provide retionale why is this patch needed.

-- 
Thx and BRs,
Tengfei Fan
Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: modify the wrong compatible name
Posted by Dmitry Baryshkov 1 year, 11 months ago 
On Wed, 24 Jan 2024 at 04:33, Tengfei Fan <quic_tengfan@quicinc.com> wrote:
>
> Use right compatible name "qcom,sm4450-tlmm" instead of
> "qcom,sm4450-pinctrl".
>
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
> index bb08ca5a1509..bb675c8ec220 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
> @@ -17,7 +17,7 @@ allOf:
>
>  properties:
>    compatible:
> -    const: qcom,sm4450-pinctrl
> +    const: qcom,sm4450-tlmm

Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl")

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


>
>    reg:
>      maxItems: 1
> --
> 2.17.1
>
>


--
With best wishes
Dmitry
Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: modify the wrong compatible name
Posted by Tengfei Fan 1 year, 11 months ago 

On 1/24/2024 11:33 AM, Dmitry Baryshkov wrote:
> On Wed, 24 Jan 2024 at 04:33, Tengfei Fan <quic_tengfan@quicinc.com> wrote:
>>
>> Use right compatible name "qcom,sm4450-tlmm" instead of
>> "qcom,sm4450-pinctrl".
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
>> index bb08ca5a1509..bb675c8ec220 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
>> @@ -17,7 +17,7 @@ allOf:
>>
>>   properties:
>>     compatible:
>> -    const: qcom,sm4450-pinctrl
>> +    const: qcom,sm4450-tlmm
> 
> Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl")
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Thanks Dmitry. I will inside this "Fixes" tage into commit message in 
the next patch series.

> 
> 
>>
>>     reg:
>>       maxItems: 1
>> --
>> 2.17.1
>>
>>
> 
> 
> --
> With best wishes
> Dmitry

-- 
Thx and BRs,
Tengfei Fan
Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: modify the wrong compatible name
Posted by Dmitry Baryshkov 1 year, 11 months ago 
On Thu, 25 Jan 2024 at 03:18, Tengfei Fan <quic_tengfan@quicinc.com> wrote:
>
>
>
> On 1/24/2024 11:33 AM, Dmitry Baryshkov wrote:
> > On Wed, 24 Jan 2024 at 04:33, Tengfei Fan <quic_tengfan@quicinc.com> wrote:
> >>
> >> Use right compatible name "qcom,sm4450-tlmm" instead of
> >> "qcom,sm4450-pinctrl".
> >>
> >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> >> ---
> >>   Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
> >> index bb08ca5a1509..bb675c8ec220 100644
> >> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
> >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
> >> @@ -17,7 +17,7 @@ allOf:
> >>
> >>   properties:
> >>     compatible:
> >> -    const: qcom,sm4450-pinctrl
> >> +    const: qcom,sm4450-tlmm
> >
> > Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl")
> >
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> Thanks Dmitry. I will inside this "Fixes" tage into commit message in
> the next patch series.

No need to, unless there are other changes to the patches. Such
trailers are picked up automatically.

>
> >
> >
> >>
> >>     reg:
> >>       maxItems: 1
> >> --
> >> 2.17.1
> >>
> >>
> >
> >
> > --
> > With best wishes
> > Dmitry
>
> --
> Thx and BRs,
> Tengfei Fan



-- 
With best wishes
Dmitry
Re: [PATCH 1/2] dt-bindings: pinctrl: qcom: modify the wrong compatible name
Posted by Tengfei Fan 1 year, 11 months ago 

On 1/25/2024 9:20 AM, Dmitry Baryshkov wrote:
> On Thu, 25 Jan 2024 at 03:18, Tengfei Fan <quic_tengfan@quicinc.com> wrote:
>>
>>
>>
>> On 1/24/2024 11:33 AM, Dmitry Baryshkov wrote:
>>> On Wed, 24 Jan 2024 at 04:33, Tengfei Fan <quic_tengfan@quicinc.com> wrote:
>>>>
>>>> Use right compatible name "qcom,sm4450-tlmm" instead of
>>>> "qcom,sm4450-pinctrl".
>>>>
>>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>>> ---
>>>>    Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
>>>> index bb08ca5a1509..bb675c8ec220 100644
>>>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
>>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
>>>> @@ -17,7 +17,7 @@ allOf:
>>>>
>>>>    properties:
>>>>      compatible:
>>>> -    const: qcom,sm4450-pinctrl
>>>> +    const: qcom,sm4450-tlmm
>>>
>>> Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl")
>>>
>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>
>> Thanks Dmitry. I will inside this "Fixes" tage into commit message in
>> the next patch series.
> 
> No need to, unless there are other changes to the patches. Such
> trailers are picked up automatically.

Thank you for the heads-up.

> 
>>
>>>
>>>
>>>>
>>>>      reg:
>>>>        maxItems: 1
>>>> --
>>>> 2.17.1
>>>>
>>>>
>>>
>>>
>>> --
>>> With best wishes
>>> Dmitry
>>
>> --
>> Thx and BRs,
>> Tengfei Fan
> 
> 
> 

-- 
Thx and BRs,
Tengfei Fan

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.