[v1] arm64: dts: qcom: qcm6490-idp: Add support for PM7250B PMIC

[PATCH RESEND] arm64: dts: qcom: qcm6490-idp: Add support for PM7250B PMIC

Posted by Umang Chheda 1 year, 11 months ago

qcm6490-idp platform supports PM7250B PMIC as well.
Add support for the same.

Signed-off-by: Umang Chheda <quic_uchheda@quicinc.com>
---
 arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
index 03e97e27d16d..2a6e4907c5ee 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
@@ -5,8 +5,13 @@
 
 /dts-v1/;
 
+/* PM7250B is configured to use SID8/9 */
+#define PM7250B_SID 8
+#define PM7250B_SID1 9
+
 #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
 #include "sc7280.dtsi"
+#include "pm7250b.dtsi"
 #include "pm7325.dtsi"
 #include "pm8350c.dtsi"
 #include "pmk8350.dtsi"
-- 
2.25.1

Re: [PATCH RESEND] arm64: dts: qcom: qcm6490-idp: Add support for PM7250B PMIC

Posted by Dmitry Baryshkov 1 year, 11 months ago

On Tue, 23 Jan 2024 at 12:28, Umang Chheda <quic_uchheda@quicinc.com> wrote:
>
> qcm6490-idp platform supports PM7250B PMIC as well.
> Add support for the same.

The platform can not "support" PMIC. Please fix the commit message.

>
> Signed-off-by: Umang Chheda <quic_uchheda@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index 03e97e27d16d..2a6e4907c5ee 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -5,8 +5,13 @@
>
>  /dts-v1/;
>
> +/* PM7250B is configured to use SID8/9 */
> +#define PM7250B_SID 8
> +#define PM7250B_SID1 9
> +
>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>  #include "sc7280.dtsi"
> +#include "pm7250b.dtsi"
>  #include "pm7325.dtsi"
>  #include "pm8350c.dtsi"
>  #include "pmk8350.dtsi"
> --
> 2.25.1
>
>


-- 
With best wishes
Dmitry

Re: [PATCH RESEND] arm64: dts: qcom: qcm6490-idp: Add support for PM7250B PMIC

Posted by Umang Chheda 1 year, 10 months ago

Hi Dmitry,

On 1/23/2024 5:48 PM, Dmitry Baryshkov wrote:
> On Tue, 23 Jan 2024 at 12:28, Umang Chheda <quic_uchheda@quicinc.com> wrote:
>>
>> qcm6490-idp platform supports PM7250B PMIC as well.
>> Add support for the same.
> 
> The platform can not "support" PMIC. Please fix the commit message.
Shall I change the commit message as below in the next patch ? 
"Add PM7250B PMIC support for qcm6490-idp"

Thanks,
Umang

> 
>>
>> Signed-off-by: Umang Chheda <quic_uchheda@quicinc.com>
>> ---

Re: [PATCH RESEND] arm64: dts: qcom: qcm6490-idp: Add support for PM7250B PMIC

Posted by Dmitry Baryshkov 1 year, 10 months ago

On Thu, 25 Jan 2024 at 10:10, Umang Chheda <quic_uchheda@quicinc.com> wrote:
>
> Hi Dmitry,
>
> On 1/23/2024 5:48 PM, Dmitry Baryshkov wrote:
> > On Tue, 23 Jan 2024 at 12:28, Umang Chheda <quic_uchheda@quicinc.com> wrote:
> >>
> >> qcm6490-idp platform supports PM7250B PMIC as well.
> >> Add support for the same.
> >
> > The platform can not "support" PMIC. Please fix the commit message.
> Shall I change the commit message as below in the next patch ?
> "Add PM7250B PMIC support for qcm6490-idp"

This is also not accurate. You are not adding support for the PMIC.
You are describing PMICs present on the board.

-- 
With best wishes
Dmitry

Re: [PATCH RESEND] arm64: dts: qcom: qcm6490-idp: Add support for PM7250B PMIC

Posted by Konrad Dybcio 1 year, 10 months ago


On 1/25/24 09:26, Dmitry Baryshkov wrote:
> On Thu, 25 Jan 2024 at 10:10, Umang Chheda <quic_uchheda@quicinc.com> wrote:
>>
>> Hi Dmitry,
>>
>> On 1/23/2024 5:48 PM, Dmitry Baryshkov wrote:
>>> On Tue, 23 Jan 2024 at 12:28, Umang Chheda <quic_uchheda@quicinc.com> wrote:
>>>>
>>>> qcm6490-idp platform supports PM7250B PMIC as well.
>>>> Add support for the same.
>>>
>>> The platform can not "support" PMIC. Please fix the commit message.
>> Shall I change the commit message as below in the next patch ?
>> "Add PM7250B PMIC support for qcm6490-idp"
> 
> This is also not accurate. You are not adding support for the PMIC.
> You are describing PMICs present on the board.

Umang, consider one of:

arm64: dts: qcom: qcm6490-idp:

"Include PM7250B"

"Enable PM7250B"

"Configure PM7250B"

Konrad

Re: [PATCH RESEND] arm64: dts: qcom: qcm6490-idp: Add support for PM7250B PMIC

Posted by Umang Chheda 1 year, 10 months ago

Hi Konrad,

On 1/25/2024 3:15 PM, Konrad Dybcio wrote:
> 
> 
> On 1/25/24 09:26, Dmitry Baryshkov wrote:
>> On Thu, 25 Jan 2024 at 10:10, Umang Chheda <quic_uchheda@quicinc.com> wrote:
>>>
>>> Hi Dmitry,
>>>
>>> On 1/23/2024 5:48 PM, Dmitry Baryshkov wrote:
>>>> On Tue, 23 Jan 2024 at 12:28, Umang Chheda <quic_uchheda@quicinc.com> wrote:
>>>>>
>>>>> qcm6490-idp platform supports PM7250B PMIC as well.
>>>>> Add support for the same.
>>>>
>>>> The platform can not "support" PMIC. Please fix the commit message.
>>> Shall I change the commit message as below in the next patch ?
>>> "Add PM7250B PMIC support for qcm6490-idp"
>>
>> This is also not accurate. You are not adding support for the PMIC.
>> You are describing PMICs present on the board.
> 
> Umang, consider one of:
> 
> arm64: dts: qcom: qcm6490-idp:
> 
> "Include PM7250B"
> 
> "Enable PM7250B"
> 
> "Configure PM7250B"
> 
Ack, I have sent new version of my patch which addresses the feedback.

> Konrad

Thanks,
Umang