[PATCH] dt-bindings: timer: narrow regex for unit address to hex numbers

Krzysztof Kozlowski posted 1 patch 1 year, 11 months ago
.../devicetree/bindings/timer/arm,arch_timer_mmio.yaml          | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] dt-bindings: timer: narrow regex for unit address to hex numbers
Posted by Krzysztof Kozlowski 1 year, 11 months ago
Regular expression used to match the unit address part should not allow
non-hex numbers.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
index 7a4a6ab85970..5b9fda2a81e0 100644
--- a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
+++ b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
@@ -60,7 +60,7 @@ properties:
       be implemented in an always-on power domain."
 
 patternProperties:
-  '^frame@[0-9a-z]*$':
+  '^frame@[0-9a-f]*$':
     type: object
     additionalProperties: false
     description: A timer node has up to 8 frame sub-nodes, each with the following properties.
-- 
2.34.1
Re: [PATCH] dt-bindings: timer: narrow regex for unit address to hex numbers
Posted by Rob Herring 1 year, 10 months ago
On Tue, 23 Jan 2024 09:33:12 +0100, Krzysztof Kozlowski wrote:
> Regular expression used to match the unit address part should not allow
> non-hex numbers.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml          | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Re: [PATCH] dt-bindings: timer: narrow regex for unit address to hex numbers
Posted by Rob Herring 1 year, 10 months ago
On Tue, Jan 23, 2024 at 09:33:12AM +0100, Krzysztof Kozlowski wrote:
> Regular expression used to match the unit address part should not allow
> non-hex numbers.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml          | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> index 7a4a6ab85970..5b9fda2a81e0 100644
> --- a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> +++ b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> @@ -60,7 +60,7 @@ properties:
>        be implemented in an always-on power domain."
>  
>  patternProperties:
> -  '^frame@[0-9a-z]*$':
> +  '^frame@[0-9a-f]*$':

Technically, it should be '+' rather than '*'. But I'm pretty sure 
generically we check that node name can't end with '@'.