[PATCH V4 0/3] Add reset controller driver for ums512

Zhifeng Tang posted 3 patches 1 year, 11 months ago
.../bindings/clock/sprd,ums512-clk.yaml       |   3 +
arch/arm64/boot/dts/sprd/ums512.dtsi          |   9 +
drivers/clk/sprd/Makefile                     |   1 +
drivers/clk/sprd/common.c                     |   1 +
drivers/clk/sprd/common.h                     |   2 +
drivers/clk/sprd/reset.c                      |  78 ++++++
drivers/clk/sprd/reset.h                      |  30 +++
drivers/clk/sprd/ums512-clk.c                 | 240 ++++++++++++++++++
include/dt-bindings/reset/sprd,ums512-reset.h | 203 +++++++++++++++
9 files changed, 567 insertions(+)
create mode 100644 drivers/clk/sprd/reset.c
create mode 100644 drivers/clk/sprd/reset.h
create mode 100644 include/dt-bindings/reset/sprd,ums512-reset.h
[PATCH V4 0/3] Add reset controller driver for ums512
Posted by Zhifeng Tang 1 year, 11 months ago
From: "zhifeng.tang" <zhifeng.tang@unisoc.com>

In most of Sprd SOCs,The clock controller register block also
contains reset bits for some of these peripherals,so reset
controller and clock provider are combined together as a block,
and put it under the driver/clk/.

Changes in v4:
  - Add description why reset controller put it under the driver/clk/

Changes in v3:
  - Fix the driver patch is overwritten by cover letter
  
Changes in v2:
  - The binding file is combined into one patch

zhifeng.tang (3):
  dt-bindings: reset: Add reset controller bindings for Unisoc's ums512
  clk: sprd: Add reset controller driver for ums512
  arm64: dts: sprd: Add reset controller driver for UMS512

 .../bindings/clock/sprd,ums512-clk.yaml       |   3 +
 arch/arm64/boot/dts/sprd/ums512.dtsi          |   9 +
 drivers/clk/sprd/Makefile                     |   1 +
 drivers/clk/sprd/common.c                     |   1 +
 drivers/clk/sprd/common.h                     |   2 +
 drivers/clk/sprd/reset.c                      |  78 ++++++
 drivers/clk/sprd/reset.h                      |  30 +++
 drivers/clk/sprd/ums512-clk.c                 | 240 ++++++++++++++++++
 include/dt-bindings/reset/sprd,ums512-reset.h | 203 +++++++++++++++
 9 files changed, 567 insertions(+)
 create mode 100644 drivers/clk/sprd/reset.c
 create mode 100644 drivers/clk/sprd/reset.h
 create mode 100644 include/dt-bindings/reset/sprd,ums512-reset.h

-- 
2.17.1
Re: [PATCH V4 0/3] Add reset controller driver for ums512
Posted by Stephen Boyd 1 year, 8 months ago
Quoting Zhifeng Tang (2024-01-22 18:56:10)
> From: "zhifeng.tang" <zhifeng.tang@unisoc.com>
> 
> In most of Sprd SOCs,The clock controller register block also
> contains reset bits for some of these peripherals,so reset
> controller and clock provider are combined together as a block,
> and put it under the driver/clk/.
> 
> Changes in v4:
>   - Add description why reset controller put it under the driver/clk/

Please use an auxiliary device and put the code almost entirely under
drivers/reset/. You can still have the data tables in the clk driver if
you want, but I don't see why an auxiliary device can't be used.