Add support for RK3588 HDMI/DP Combo PHY

[PATCH 0/3] Add support for RK3588 HDMI/DP Combo PHY

Posted by Cristian Ciocaltea 1 year, 11 months ago

Add driver and bindings to support the Rockchip HDMI/eDP TX Combo PHY 
found on RK3588 SoC.

The PHY is based on a Samsung IP block and supports HDMI 2.1 TMDS, FRL
and eDP links.

The HDMI link has been tested on Rock 5B and EVB1 boards.

Cristian Ciocaltea (3):
  dt-bindings: soc: rockchip: Add rk3588 hdptxphy syscon
  dt-bindings: phy: Add Rockchip HDMI/DP Combo PHY schema
  phy: rockchip: Add Samsung HDMI/DP Combo PHY driver

 .../phy/rockchip,rk3588-hdptx-phy.yaml        |   96 +
 .../devicetree/bindings/soc/rockchip/grf.yaml |    1 +
 drivers/phy/rockchip/Kconfig                  |    8 +
 drivers/phy/rockchip/Makefile                 |    1 +
 .../phy/rockchip/phy-rockchip-samsung-hdptx.c | 2045 +++++++++++++++++
 5 files changed, 2151 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml
 create mode 100644 drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c

-- 
2.43.0

Re: [PATCH 0/3] Add support for RK3588 HDMI/DP Combo PHY

Posted by Cristian Ciocaltea 1 year, 11 months ago

On 1/19/24 21:38, Cristian Ciocaltea wrote:
> Add driver and bindings to support the Rockchip HDMI/eDP TX Combo PHY 
> found on RK3588 SoC.
> 
> The PHY is based on a Samsung IP block and supports HDMI 2.1 TMDS, FRL
> and eDP links.
> 
> The HDMI link has been tested on Rock 5B and EVB1 boards.

I missed to highlight there is no eDP support provided by the current
implementation.  Downstream kernel has a separate driver for that and at
the moment I don't have the hardware to wire this up.

Will include this statement in v2.

Re: [PATCH 0/3] Add support for RK3588 HDMI/DP Combo PHY

Posted by Andy Yan 1 year, 11 months ago

Hi Cristian:

On 1/20/24 07:41, Cristian Ciocaltea wrote:
> On 1/19/24 21:38, Cristian Ciocaltea wrote:
>> Add driver and bindings to support the Rockchip HDMI/eDP TX Combo PHY
>> found on RK3588 SoC.
>>
>> The PHY is based on a Samsung IP block and supports HDMI 2.1 TMDS, FRL
>> and eDP links.
>>
>> The HDMI link has been tested on Rock 5B and EVB1 boards.
> 
> I missed to highlight there is no eDP support provided by the current
> implementation.  Downstream kernel has a separate driver for that and at
> the moment I don't have the hardware to wire this up.
> 
> Will include this statement in v2.

The PHY is used for HDMI and eDP on rk3588, and should used be exclusively.
so I think should s/DP/eDP/ in  all description.

Re: [PATCH 0/3] Add support for RK3588 HDMI/DP Combo PHY

Posted by Cristian Ciocaltea 1 year, 11 months ago

On 1/22/24 12:10, Andy Yan wrote:
> Hi Cristian:
> 
> On 1/20/24 07:41, Cristian Ciocaltea wrote:
>> On 1/19/24 21:38, Cristian Ciocaltea wrote:
>>> Add driver and bindings to support the Rockchip HDMI/eDP TX Combo PHY
>>> found on RK3588 SoC.
>>>
>>> The PHY is based on a Samsung IP block and supports HDMI 2.1 TMDS, FRL
>>> and eDP links.
>>>
>>> The HDMI link has been tested on Rock 5B and EVB1 boards.
>>
>> I missed to highlight there is no eDP support provided by the current
>> implementation.  Downstream kernel has a separate driver for that and at
>> the moment I don't have the hardware to wire this up.
>>
>> Will include this statement in v2.
> 
> The PHY is used for HDMI and eDP on rk3588, and should used be exclusively.
> so I think should s/DP/eDP/ in  all description.

Right, will make this consistent.

Thanks,
Cristian

Re: (subset) [PATCH 0/3] Add support for RK3588 HDMI/DP Combo PHY

Posted by Heiko Stuebner 1 year, 11 months ago

On Fri, 19 Jan 2024 21:38:00 +0200, Cristian Ciocaltea wrote:
> Add driver and bindings to support the Rockchip HDMI/eDP TX Combo PHY
> found on RK3588 SoC.
> 
> The PHY is based on a Samsung IP block and supports HDMI 2.1 TMDS, FRL
> and eDP links.
> 
> The HDMI link has been tested on Rock 5B and EVB1 boards.
> 
> [...]

Applied, thanks!

[1/3] dt-bindings: soc: rockchip: Add rk3588 hdptxphy syscon
      commit: 738227ab42fe0c6047f932aef11b9fd647d203f9

I've grabbed this one already, to keep my GRFs together :-)


Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

Re: (subset) [PATCH 0/3] Add support for RK3588 HDMI/DP Combo PHY

Posted by Cristian Ciocaltea 1 year, 11 months ago

On 1/25/24 21:56, Heiko Stuebner wrote:
> On Fri, 19 Jan 2024 21:38:00 +0200, Cristian Ciocaltea wrote:
>> Add driver and bindings to support the Rockchip HDMI/eDP TX Combo PHY
>> found on RK3588 SoC.
>>
>> The PHY is based on a Samsung IP block and supports HDMI 2.1 TMDS, FRL
>> and eDP links.
>>
>> The HDMI link has been tested on Rock 5B and EVB1 boards.
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/3] dt-bindings: soc: rockchip: Add rk3588 hdptxphy syscon
>       commit: 738227ab42fe0c6047f932aef11b9fd647d203f9
> 
> I've grabbed this one already, to keep my GRFs together :-)

Great, thanks!